add option to use dynamic heat source#32
Open
puente-tamu wants to merge 1 commit into
Open
Conversation
puente-tamu
force-pushed
the
dynamic_heat_source
branch
from
6bf7dd6 to
5603402
Compare
streeve
reviewed
May 28, 2026
|
|
||
| // heat source parameter constants | ||
| for ( std::size_t d = 0; d < 3; ++d ) | ||
| dynamic_beam_ = ( db.source.shape == "dynamic" ); |
Contributor
There was a problem hiding this comment.
Suggestion: move this logic into a new HeatSource class that gets called here in the solver. I think this new complexity warrants some separation
| return ( dist_to_beam[0] * dist_to_beam[0] * A_inv_[0] ) + | ||
| ( dist_to_beam[1] * dist_to_beam[1] * A_inv_[1] ) + | ||
| ( dist_to_beam[2] * dist_to_beam[2] * A_inv_[2] ); | ||
| if ( !dynamic_beam_ ) |
Contributor
There was a problem hiding this comment.
I would expect this to look something like:
return heat_source.weight( dx, dy, dz ... );
| double depth_; // heat source depth (= two_sigma[2]) | ||
|
|
||
| public: | ||
| Solver( Inputs db, LocalMeshType local_mesh ) |
Contributor
There was a problem hiding this comment.
Suggested change
| Solver( Inputs db, LocalMeshType local_mesh ) | |
| Solver( Inputs db, LocalMeshType local_mesh, HeatSource heat_source ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added option to use dynamic heat source from Coleman et al. Added dynamic heat source in Finch_Solver to have m,k options to change heat source shape. Backwards compatible such that if no "shape" is specified in user input for the heat "source" the default is the original gaussian distribution. Changes were made in Finch_Inputs to account for this.