Skip to content

Reorganization for compatibility of solidification data with multilayer ExaCA#28

Merged
MattRolchigo merged 6 commits into
ORNL-MDF:mainfrom
MattRolchigo:multilayer_finch_exaca
Apr 13, 2026
Merged

Reorganization for compatibility of solidification data with multilayer ExaCA#28
MattRolchigo merged 6 commits into
ORNL-MDF:mainfrom
MattRolchigo:multilayer_finch_exaca

Conversation

@MattRolchigo
Copy link
Copy Markdown
Collaborator

@MattRolchigo MattRolchigo commented Jun 4, 2025

Generalized function to obtain Finch's time-temperature history data to append to an existing view (which may already contain prior layers' time-temperature history), rather than returning a new view.

@MattRolchigo MattRolchigo marked this pull request as draft June 4, 2025 19:41
@MattRolchigo MattRolchigo requested a review from streeve June 4, 2025 19:41
@MattRolchigo MattRolchigo marked this pull request as ready for review June 4, 2025 19:58
@MattRolchigo MattRolchigo force-pushed the multilayer_finch_exaca branch from 0bdc477 to 1a0c146 Compare June 13, 2025 21:01
@MattRolchigo MattRolchigo force-pushed the multilayer_finch_exaca branch from 1a0c146 to 7fd1bb4 Compare January 23, 2026 22:28
@MattRolchigo
Copy link
Copy Markdown
Collaborator Author

@streeve I think we're good to merge this whenever, it'll make PR #398 in ExaCA easier to debug

Comment thread src/Finch_Run.hpp
Comment thread src/Finch_Run.hpp
@MattRolchigo MattRolchigo force-pushed the multilayer_finch_exaca branch from 3655cbc to 7bf2abb Compare February 27, 2026 05:21
Copy link
Copy Markdown
Contributor

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't Finch do multiple layers in a standalone input file?

Comment thread src/Finch_Inputs.hpp Outdated
Comment thread src/Finch_Inputs.hpp Outdated
Comment thread src/Finch_Inputs.hpp
Comment thread src/Finch_Inputs.hpp
Comment thread src/Finch_Inputs.hpp Outdated
@MattRolchigo MattRolchigo merged commit 9f79a05 into ORNL-MDF:main Apr 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants