Skip to content

Fix GHA push to s3 on merge to master#101

Merged
hannahilea merged 4 commits intomasterfrom
hr/fix-osx-tarball-push
Jan 26, 2026
Merged

Fix GHA push to s3 on merge to master#101
hannahilea merged 4 commits intomasterfrom
hr/fix-osx-tarball-push

Conversation

@hannahilea
Copy link
Contributor

No description provided.

@jgallagher59701
Copy link
Member

I made a new AWS Key for this this, and just this, repo. I recorded it in the repo's Settings -> Secrets and variables -> Actions table. The key is bound to a new user in our AWS account with very limited permissions.

@jgallagher59701
Copy link
Member

Re-running the GHAs.

@jgallagher59701
Copy link
Member

I think the "Build on macos-15" action may have failed because I did not complete making the AWS Key. I just checked and the last button click was left undone. The permissions on the Key do allow S3 PutObject, so it should work.

@hannahilea
Copy link
Contributor Author

Ah, okay! We can rerun that job once the intel job completes, since if the key is now created it should succeed this time.

@hannahilea
Copy link
Contributor Author

@jgallagher59701 does the token exist now? I made a fail-faster branch here https://github.com/OPENDAP/hyrax-dependencies/actions/runs/21369747269/job/61510919462?pr=103 and

upload failed: ./delete-me-test-file-macos-15-153.txt to s3://opendap.travis.build/delete-me-test-file-macos-15-153.txt An error occurred (AccessDenied) when calling the PutObject operation: User: arn:aws:iam::747931985039:user/GHA-hyrax-dependencies is not authorized to perform: s3:PutObject on resource: "arn:aws:s3:::opendap.travis.build/delete-me-test-file-macos-15-153.txt" because no identity-based policy allows the s3:PutObject action

@jgallagher59701
Copy link
Member

@jgallagher59701 does the token exist now? I made a fail-faster branch here https://github.com/OPENDAP/hyrax-dependencies/actions/runs/21369747269/job/61510919462?pr=103 and

upload failed: ./delete-me-test-file-macos-15-153.txt to s3://opendap.travis.build/delete-me-test-file-macos-15-153.txt An error occurred (AccessDenied) when calling the PutObject operation: User: arn:aws:iam::747931985039:user/GHA-hyrax-dependencies is not authorized to perform: s3:PutObject on resource: "arn:aws:s3:::opendap.travis.build/delete-me-test-file-macos-15-153.txt" because no identity-based policy allows the s3:PutObject action

Yes the token does exist. So I'm flummoxed. There's no way I know of to see if the token is being used. How would we know that?

@hannahilea
Copy link
Contributor Author

Ah, okay. I went and looked at the credentials in the aws console, and it looks like that user has s3 permissions for different buckets than the one I'm pushing to here (s3://opendap.travis.build, for parity with the site the other hyrax-dependencies are being pushed.)

This means we have a choice: should I update this job to push the hyrax-dependencies built for osx to s3::opendap.github.actions.build, or should I update the IAM role to allow write access to s3://opendap.travis.build?

@hannahilea
Copy link
Contributor Author

(determined via slack that we should update the bucket)

@hannahilea hannahilea merged commit 9463603 into master Jan 26, 2026
3 checks passed
@hannahilea hannahilea deleted the hr/fix-osx-tarball-push branch January 26, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants