Skip to content

Fix travis build step for docker image #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hannahilea merged 8 commits into from
Feb 4, 2026
Merged

Fix travis build step for docker image #1251

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4eec142
do not source build-rhel-docker from travis
hannahilea Feb 3, 2026
95d4c5e
also remove from build script
hannahilea Feb 3, 2026
46add48
also update comment
hannahilea Feb 3, 2026
85c51e4
make script executable
hannahilea Feb 4, 2026
7efea8b
add .
hannahilea Feb 4, 2026
e12fc19
path sadness
hannahilea Feb 4, 2026
ae299b7
add name to gha job for better legibility
hannahilea Feb 4, 2026
7e6cd55
update sh to bash
hannahilea Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,11 +207,15 @@ jobs:
- export DIST=el8
- export OS=rocky8
- export BES_REPO_DIR=${TRAVIS_BUILD_DIR}
# Note: We use `source` instead of `bash` here so that we
# have downstream access to the environment variable
# `BUILD_VERSION_TAG` that must be exported AFTER the image
- ${TRAVIS_BUILD_DIR}/travis/build-rhel-docker.sh
Copy link
Contributor

@ndp-opendap ndp-opendap Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file travis/build-rhel-docker.sh needs its permission changed to be an executable.

# Note: We need downstream access to the environment variable
# `BUILD_VERSION_TAG` that can only be determined AFTER the image
# is built:
- source ${TRAVIS_BUILD_DIR}/travis/build-rhel-docker.sh
- |
export BES_VERSION="$(docker run --rm ${SNAPSHOT_IMAGE_TAG} -c 'cat bes_VERSION')"
export BUILD_VERSION_TAG="opendap/${DOCKER_NAME}:${BES_VERSION}"
echo "Tagging image with BES version: ${BUILD_VERSION_TAG}"
docker tag ${SNAPSHOT_IMAGE_TAG} ${BUILD_VERSION_TAG}

- stage: build-and-package
name: "dist"
Expand Down
11 changes: 0 additions & 11 deletions travis/build-rhel-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,4 @@ docker build \
echo "Docker build complete!"
docker image ls -a

loggy "Tagging the image with its version number..."
export BES_VERSION="$(docker run --rm ${SNAPSHOT_IMAGE_TAG} -c 'cat bes_VERSION')"
echo "BES_VERSION is ${BES_VERSION}"
export BUILD_VERSION_TAG="opendap/${DOCKER_NAME}:${BES_VERSION}"
echo "BUILD_VERSION_TAG is ${BUILD_VERSION_TAG}"
docker tag ${SNAPSHOT_IMAGE_TAG} ${BUILD_VERSION_TAG}

loggy "Complete!"

# Because this script is often sourced (at least by travis),
# unset these commands to prevent spurious downstream failures
set +eux
Loading