Remove Indivuidual Response #1570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuyutsu Rai <[email protected]>
Signed-off-by: Yuyutsu Rai <[email protected]>
berroar
requested changes
Jan 15, 2025
| @@ -50,3 +51,17 @@ def test_resolving_message_raises_exception_on_error(publisher): | |||
| b"test-message", | |||
| fulfilment_request_transaction_id=str(uuid4()), | |||
| ) | |||
|
|
|||
|
|
|||
| def test_log_publisher_publish(): | |||
There was a problem hiding this comment.
How come we needed this new test?
There was a problem hiding this comment.
LogPublisher was covered intest_individual_response.py but was not tested directly.
| @@ -15,7 +15,6 @@ EQ_REDIS_HOST=localhost | |||
| EQ_REDIS_PORT=6379 | |||
| EQ_SECRETS_FILE=dev-secrets.yml | |||
| EQ_KEYS_FILE=dev-keys.yml | |||
| EQ_INDIVIDUAL_RESPONSE_POSTAL_DEADLINE=2021-04-28T14:00:00+00:00 | |||
There was a problem hiding this comment.
Removed the env vars here but they are passed in our workflows to the deploy_app.yaml file. So will also need to update the pipelines and terraform and test deploying runner with the vars removed.
There was a problem hiding this comment.
Updated and Tested. New PRs have been added to the card:
petechd
reviewed
Jan 28, 2025
petechd
reviewed
Jan 28, 2025
petechd
reviewed
Jan 28, 2025
Signed-off-by: Yuyutsu Rai <[email protected]>
Signed-off-by: Yuyutsu Rai <[email protected]>
petechd
reviewed
Feb 6, 2025
petechd
reviewed
Feb 6, 2025
templates/sectionsummary.html
Outdated
| @@ -30,7 +30,8 @@ <h1>{{ content.summary.title }}</h1> | |||
| {% set add_link_text = summary.add_link_text %} | |||
| {% set empty_list_text = summary.empty_list_text %} | |||
| {% set list_title = summary.title %} | |||
| <div {{ 'class="ons-u-mb-l"' if not loop.last }} data-qa="{{ summary.list_name }}-list-summary"> | |||
There was a problem hiding this comment.
Why was this change added? Seems unrelated to your changes?
There was a problem hiding this comment.
Oh I think was an accidental reformat. Reverted now 👍
Signed-off-by: Yuyutsu Rai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Remove Individual Response (IR) Functionality from Runner
New Test was added for LogPublisher and some tests were removed too.
How to review
Check if Runner works as expected.
Tests Pass and changes make sense.
Check if all references to IR have been removed.
Checklist