Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dis2198 implement post and put dataset api requests #81

Conversation

SarahJohnsonONS
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

What

Updated the DatasetAPIClient to generate the correct URL to be able to submit metadata to the endpoint, following clarification from Fran/Baratha.

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

  • Yes
  • No
    Please write a brief description of why test coverage is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

  • Yes
  • No
    Please write a brief description of why documentation is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Related issues

Jira ticket: https://jira.ons.gov.uk/browse/DIS-2198

How to review

Create a DatasetAPIClient and pass it valid dataset_api_url, dataset_path and edition_path values (you'll need to port forward to the Dataset API and Identity API). Try dataset_path="trade" and edition_path="time-series". Run get_path() and check that you get a 200 response.

@SarahJohnsonONS SarahJohnsonONS merged commit 5e10cc0 into develop Feb 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants