Dis2198 implement post
and put
dataset api requests
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What
Updated the
DatasetAPIClient
to generate the correct URL to be able to submit metadata to the endpoint, following clarification from Fran/Baratha.Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
Jira ticket: https://jira.ons.gov.uk/browse/DIS-2198
How to review
Create a DatasetAPIClient and pass it valid
dataset_api_url
,dataset_path
andedition_path
values (you'll need to port forward to the Dataset API and Identity API). Trydataset_path="trade"
andedition_path="time-series"
. Runget_path()
and check that you get a 200 response.