Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed error handling in _handle_request and get_path #78

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

SarahJohnsonONS
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

What

Removed error handling in BaseHttpClient._handle_request() and DatasetAPIClient.get_path() methods, so that this can be handled within the pipeline itself.

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

  • Yes
  • No
    No new functionality
  • Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

  • Yes
  • No
    Please write a brief description of why documentation is not necessary here.
  • Not as part of this ticket. (Could be done at a later point)

Related issues

N/a

How to review

Create a DatasetAPIClient with valid/invalid URLs and dataset_ids and check that the correct status codes are returned when calling get_path.

@SarahJohnsonONS SarahJohnsonONS merged commit 6988259 into develop Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants