Removed error handling in _handle_request and get_path #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What
Removed error handling in
BaseHttpClient._handle_request()
andDatasetAPIClient.get_path()
methods, so that this can be handled within the pipeline itself.Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
No new functionality
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
N/a
How to review
Create a
DatasetAPIClient
with valid/invalid URLs anddataset_id
s and check that the correct status codes are returned when callingget_path
.