-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatasetAPIClient.get_path()
method added
#76
Open
SarahJohnsonONS
wants to merge
12
commits into
develop
Choose a base branch
from
2198-metadata-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded handler to give up retries if 404 error
emmaons
reviewed
Jan 28, 2025
emmaons
previously approved these changes
Jan 29, 2025
emmaons
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
What
get_path()
method added toDatasetAPIClient
, to be able to check that a specified dataset ID exists within the Dataset API and determine whether aPOST
orPUT
request should be submitted.Testing
Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.
Please write a brief description of why test coverage is not necessary here.
Documentation
Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.
Please write a brief description of why documentation is not necessary here.
Related issues
Ticket link: https://jira.ons.gov.uk/browse/DIS-2423
How to review
Create a
DatasetAPIClient
usingurl_netloc="http://localhost:22000/datasets"
andurl_path="cpih"
. Check that callingget_path()
returns a 200 HTTP status code. Changeurl_path
to a nonsense string, and check that this returns a 404 status code. You'll need to port foward to the Identity API and Dataset API, and set env vars as follows: