Only set auth and permissions clients when private endpoints are enabled #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryan-p03
reviewed
Dec 11, 2025
aryan-p03
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Only set values for auth and permission clients where private endpoints are enabled as they are not required otherwise. This will stop error messages being logged in web for the config values not being set as they are not required.
How to review
Run the dataset-catalogue stack ensuring the ENABLE_PRIVATE_ENDPOINTS value is set to true. Ensure the endpoints are authenticated as expected - e.g. only admins and publishers have access to PUT, POST, and DELETE endpoints.
Run the dataset-catalogue stack ensuring the ENABLE_PRIVATE_ENDPOINTS value is set to false. Ensure the GET endpoints still work returning only published data. PUT, POST, and DELETE endpoints should not be available.
Who can review
Anyone.