Feature/publish content to search in the dataset api #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # features/static_versions_put.feature
api/versions.go
Outdated
| searchContentUpdatedEvent := map[string]interface{}{ | ||
| "dataset_id": updatedVersion.DatasetID, | ||
| "uri": updatedVersion.Links.Version.HRef, | ||
| "title": updatedVersion.Edition, |
Contributor
There was a problem hiding this comment.
I think this should be updatedVersion.EditionTitle
| "uri": updatedVersion.Links.Version.HRef, | ||
| "title": updatedVersion.Edition, | ||
| "content_type": updatedVersion.Type, | ||
| } |
Contributor
There was a problem hiding this comment.
Also, if making the above change I think the edition id still needs to be included based on the swagger spec, so you'd probably need
"edition": updatedVersion.Edition
added to the object as well
api/versions.go
Outdated
| } else { | ||
| go func() { | ||
| api.searchContentUpdatedProducer.Producer.Output() <- kafka.BytesMessage{Value: jsonBytes, Context: ctx} | ||
| log.Info(ctx, "putState endpoint: sent search content update to kafka", logData) |
Contributor
There was a problem hiding this comment.
I think at this point it's only been queued to the channel, not actually sent. So it might be worth changing it to something like -
putState endpoint: queued search content update for kafka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When a version is put to published, a message needs to go on the search-content-updated kafka topic so that the search service can make the dataset available to be searched for.
Jira - https://officefornationalstatistics.atlassian.net/browse/DIS-3448?atlOrigin=eyJpIjoiYjExYTg5MjI2MmY2NDQ4MGJmY2MzODk2OGY4N2QwZDUiLCJwIjoiaiJ9
How to review
With the dataset-catalogue compose stack running, have a dataset with the state
approved.Use the put state endpoint to change this to published with:
and a body of
Check the kafka topic with (this way worked for me, I'm not sure if theres an easier way), executing into one of the kafka containers with
docker exec -it int-dataset-catalogue-kafka-3-1 /bin/bashThen check the kafka topic with:
Check that the json message is put on the topic with the expected details.
Who can review
Anyone