Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/endpoint substring fix #224

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

gedge
Copy link
Contributor

@gedge gedge commented Jan 30, 2024

the below text is shamelessly stolen from #150 but my PR includes tests 😁

What

Proxies were being used when there was a substring match (e.g. /files proxy was being used for /filesize requests) so the string builds have been updated to ensure the following logic:

  • either: end of string exactly
  • or: the remaining segment must begin with a /, and could be any length

This would mean in this example /files, /files/ and /files/id would all resolve, but /filesize would not

How to review

Ensure existing page types being routed through these 2 proxy string builders continue to work

  • test both publishing and web journeys!

Who can review

anyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants