Remove Title from PanelBlock #90
Conversation
cms/core/blocks/panels.py
Outdated
| label = _("Warning/Announcement Panel") | ||
|
|
||
|
|
||
| class InfoErrorSuccessPanelBlock(blocks.StructBlock): |
There was a problem hiding this comment.
Note that following further info based on user research, this is likely not needed either. So we would have an information/warning only. Can you confirm with Gill/Julia and Paula.
There was a problem hiding this comment.
also, let's split them into separate blocks:
WarningPanelBlock
InformationPanelBlock
AnnouncementPanelBlock
and all defined with a group=_("Panels") in their corresponding StreamField blocks.
|
Thanks @sanjeevz3009 I have functionally tested and working as described. I agree with @zerolab (against my own earlier suggestions) that it makes sense to have separate blocks for each panel type now, especially if there are only 3. |
Code updated. Let me know what you think now @helenb |
There was a problem hiding this comment.
Thanks @sanjeevz3009 I have tested again and all functions as expected. Added a couple of nitpicks (and will wait to approve till we know about the announcement panel)
cms/core/blocks/panels.py
Outdated
|
|
||
| def get_context(self, value: dict, parent_context: dict | None = None) -> dict: | ||
| context: dict = super().get_context(value, parent_context) | ||
| context["variant"] = "info" |
There was a problem hiding this comment.
Nitpick: as this has it's own template, we don't need to pass the variant through here - it will always be 'info'
There was a problem hiding this comment.
Very true. I guess my brain was on some weird autopilot/ copy-paste mentality from one class to another haha. Or I think I was doing something then I forgot to remove it, I can't remember. Removed!
|
|
||
| def get_context(self, value: dict, parent_context: dict | None = None) -> dict: | ||
| context: dict = super().get_context(value, parent_context) | ||
| context["variant"] = "warn" |
There was a problem hiding this comment.
If we remove the announcement panel, we also won't need to pass the variant to the context here - and the template could also be renamed for clarity.
There was a problem hiding this comment.
Will update this accordingly once I receive confirmation on if we still need the announcement panel.
Thanks @helenb Will address them. Contacted the relevant people and chased up the confirmation for the announcement panel. Hopefully we get a response soon. |
What is the context of this PR?
The latest ONS Design System latest release meant that the title option for warning, announcement and bare panels has been removed. The PR for this is in the ONS DS.
Currently, in our Wagtail implementation, we still have the warning and announcement panels with the title which is redundant now.
How to review
Follow-up Actions
List any follow-up actions (if applicable), like needed documentation updates or additional testing.