DRAFT: Add custom_permission_policies app (child media implementation) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ababic
force-pushed
the
feature/child-media
branch
from
bf6d6d1 to
1a3a3ce
Compare
ababic
force-pushed
the
feature/child-media
branch
from
1a3a3ce to
4bc509f
Compare
2 tasks
ababic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Follow up to #42 that introduces a concept of 'child media' for pages and other objects, which can be used to facilitate custom permission policies.
Model objects that are considered 'parents' of media should subclass the included
MediaParentMixin, which is used to drive association of media items with instances of that model.Model objects that are considered 'children' of those parents should subclass the included
MediaChildMixin, which introduces fields to store the details of the parent object.This initial implementation focusses on solutions for image and document models, but may be extended in future to cover additional models like 'Charts', which may also need to be associated with a parent page to restrict access to specific objects in Wagtail.
How to review
TBC (will be populated when ready for review)
Follow-up Actions
TBC (will be populated when this work is finalised)