Introduce Megalinter #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenb
reviewed
Nov 25, 2024
helenb
reviewed
Nov 26, 2024
|
@AWitcherONS would you let me know when this is ready for another review? There are still some js and css files updated here that I don't think should be - but I don't know if there are more commits to come that you've not pushed yet. |
* Run CMS locally with supporting services in Docker (#38) * Added make commands * Added .env to .dockerignore * Extract dev backing services to their own compose * Added example .env file * Added runbook to the readme * Replaced comonly used commands to convenience aliases in the readme * Updated the makefile * Testing markdown rendering * Formating * Removed redundant settings in example .env * Readme fixes * Fixed typo in the README * Reverted the rename of the env_file in docker-compose.yml * Rename make commands, update the refrences in README and replace django-admin commands with make commands * Added the new section in the readme to the table of contents * Renamed the dev .env file to .development.env * Formatting + error fixes * Remove the 'expose' key from docker compose * Fixed typo Co-authored-by: Dan Braghiș <[email protected]> * Remove the dj aliases and changed the commands in README * Makefile fix * Remove the dj aliases and changed the commands in README (this time for real) * Added the make dev-init script and updated README * Attempt to format the Makefile to make CI pass * Added note about honcho picking up the mounted .env file in the README * Formating * Fixed the rendering of the warning block * Slight rewording * Added in the reword suggestion Co-authored-by: Jake Howard <[email protected]> * Replaced the warning block with an emoji * Updated outdated commands in the README * Move the prerequisites up in the README * Put the superuser auto-create in a separate make command and call it in dev-init command * Add the default superuser name and password in readme * Formating * Final comment fixes --------- Co-authored-by: Dan Braghiș <[email protected]> Co-authored-by: Jake Howard <[email protected]> * Add default heading 1 and breadcrumbs for templates that haven't yet had a banner added (#49) * Add default heading 1 and breadcrumbs for templates that haven't yet had a banner added * Don't show 2 h1s on the release calendar page * Support a mostly read-only database connection for external environment (#44) * Amend the runserver command in the Makefile (#52) * Don't show an full-screen overlay for warnings - only for errors (#51) * Move CODEOWNER file location (#53) * Use cupcake flavour * Fix lint issue + enable gitleaks --------- Co-authored-by: kacperpONS <[email protected]> Co-authored-by: Dan Braghiș <[email protected]> Co-authored-by: Jake Howard <[email protected]> Co-authored-by: Helen Chapman <[email protected]>
zerolab
reviewed
Dec 9, 2024
helenb
reviewed
Dec 9, 2024
helenb
reviewed
Dec 9, 2024
zerolab
approved these changes
Dec 9, 2024
|
LGTM - just tested it out! https://confluence.ons.gov.uk/display/NWP/Megalinter?flashId=428895879 will need to be updated as |
sanjeevz3009
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Install and fix issues for megalinter
How to review
documentation https://confluence.ons.gov.uk/display/NWP/Megalinter?flashId=428895879
Follow-up Actions