Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design system to 72.1.0 #34

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Conversation

helenb
Copy link
Contributor

@helenb helenb commented Nov 20, 2024

What is the context of this PR?

Update the design system to the latest version, and associated changes to utility classes and variable names
https://jira.ons.gov.uk/browse/CMS-209

How to review

  • Check out the branch
  • When in the docker shell, run make load-design-system-templates
  • Review various kinds of pages on your local build, but especially:
    • Documents on an analysis page
    • Related links block
    • The release calendar page (in different states)
    • The footer

See the instructions for the major design system update here: https://github.com/ONSdigital/design-system/blob/main/migration_guides/70.x.x-to-72.0.0-migration-guide.md

I have split the changes into a few different commits to make it easier to review, but it is best not to test each commit separately as some functionality will break between commits.

Note that the last commit contains some fixes and further changes after some further PRs with template changes were made.

Follow up actions

Check if any in-flight work is impacted by these changes

@helenb helenb requested a review from a team as a code owner November 20, 2024 15:10
@helenb helenb marked this pull request as draft November 21, 2024 09:51
@helenb helenb force-pushed the chore/update-design-system-CMS-209 branch from 9a8e57e to d91ce99 Compare November 21, 2024 14:17
@helenb helenb force-pushed the chore/update-design-system-CMS-209 branch from fbd11f6 to c37fb98 Compare November 21, 2024 14:52
@helenb helenb marked this pull request as ready for review November 21, 2024 14:52
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and couldn't find any fault

@MebinAbraham MebinAbraham changed the title CMS-205: Update design system version Update design system version Nov 22, 2024
@MebinAbraham MebinAbraham changed the title Update design system version Update design system to 72.1.0 Nov 22, 2024
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanjeevz3009 sanjeevz3009 self-requested a review November 22, 2024 15:34
Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down the branch and tested it locally. LGTM =)

@helenb helenb merged commit 874571d into main Nov 25, 2024
7 checks passed
@helenb helenb deleted the chore/update-design-system-CMS-209 branch November 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants