-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update design system to 72.1.0 #34
Conversation
9a8e57e
to
d91ce99
Compare
…on of the design system
… done as part of the padding and margin updates
fbd11f6
to
c37fb98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and couldn't find any fault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled down the branch and tested it locally. LGTM =)
What is the context of this PR?
Update the design system to the latest version, and associated changes to utility classes and variable names
https://jira.ons.gov.uk/browse/CMS-209
How to review
make load-design-system-templates
See the instructions for the major design system update here: https://github.com/ONSdigital/design-system/blob/main/migration_guides/70.x.x-to-72.0.0-migration-guide.md
I have split the changes into a few different commits to make it easier to review, but it is best not to test each commit separately as some functionality will break between commits.
Note that the last commit contains some fixes and further changes after some further PRs with template changes were made.
Follow up actions
Check if any in-flight work is impacted by these changes