Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for bundling #33

Merged
merged 15 commits into from
Dec 2, 2024
Merged

Initial support for bundling #33

merged 15 commits into from
Dec 2, 2024

Conversation

zerolab
Copy link
Contributor

@zerolab zerolab commented Nov 20, 2024 •
edited
Loading

What is the context of this PR?

This PR adds basic bundling functionality, ported from alpha. https://jira.ons.gov.uk/browse/CMS-205/
It also reverts #22

To-Do:

  • finish test coverage

How to review

See walkthroughs.

Screencast: https://www.loom.com/share/23a483f107e948e6994305ac365f80b1

Follow-up Actions

  • Enhance functionality (CMS-232)
    • page-level workflows
    • teams-based access for non-publishing staff
    • reduce potential impact of Slack notifications call
    • add assertNumQueries for the publish_scheduled management command
  • Add docs (e.g. how to make a page bundleable)

@zerolab zerolab requested a review from a team as a code owner November 20, 2024 12:35
@zerolab zerolab marked this pull request as draft November 20, 2024 12:35
@zerolab zerolab force-pushed the feature/bundling-base-CMS-205 branch from bd2c19e to 7e1e037 Compare November 20, 2024 16:42
@zerolab zerolab force-pushed the feature/bundling-base-CMS-205 branch from 7e1e037 to 096dfa6 Compare November 21, 2024 14:08
@zerolab zerolab marked this pull request as ready for review November 21, 2024 14:44
RealOrangeOne
RealOrangeOne reviewed Nov 21, 2024
View reviewed changes
@zerolab zerolab force-pushed the feature/bundling-base-CMS-205 branch from 19afad4 to a3ebb5d Compare November 22, 2024 09:23
@MebinAbraham MebinAbraham changed the title CMS-205: basic bundling Initial support for bundling Nov 22, 2024
@sanjeevz3009 sanjeevz3009 self-requested a review November 22, 2024 22:03
MebinAbraham
MebinAbraham reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! A lot of groundwork with good tests 🎉 Just some minor comments from me.

@nehakerung
Copy link
Contributor

LGTM - Functionally tested the bundles as shown in screencast and all is well.

@AWitcherONS
Copy link
Contributor

AWitcherONS commented Dec 2, 2024 •
edited
Loading

Functionally
But was able to create 2 bundles with same time and name how do users know which is the correct one to add to
Also will there be Search functionality for users when more bundles are created

@zerolab zerolab requested a review from MebinAbraham December 2, 2024 11:10
MebinAbraham
MebinAbraham reviewed Dec 2, 2024
View reviewed changes
@zerolab
Copy link
Contributor Author

zerolab commented Dec 2, 2024

@AWitcherONS

Functionally But was able to create 2 bundles with same time and name how do users know which is the correct one to add to.

Good shout! Addressed in 4e87b79. Chose to make the name unique.

Also will there be Search functionality for users when more bundles are created

Yes. This is what https://github.com/ONSdigital/dis-wagtail/pull/33/files#diff-53ae57b17e87f4e9aad0c8a855ff3eb351617a90fccd30f64be2308c353f97e2R62 and https://github.com/ONSdigital/dis-wagtail/pull/33/files#diff-53ae57b17e87f4e9aad0c8a855ff3eb351617a90fccd30f64be2308c353f97e2R116-R119 help with

MebinAbraham
MebinAbraham approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zerolab zerolab merged commit 3538ca7 into main Dec 2, 2024
7 checks passed
@zerolab zerolab deleted the feature/bundling-base-CMS-205 branch December 2, 2024 16:42
This was referenced Dec 2, 2024
Merged
Merged
sanjeevz3009
sanjeevz3009 reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjeevz3009 sanjeevz3009 sanjeevz3009 left review comments

@RealOrangeOne RealOrangeOne RealOrangeOne approved these changes

@MebinAbraham MebinAbraham MebinAbraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zerolab @nehakerung @AWitcherONS @RealOrangeOne @MebinAbraham @sanjeevz3009