Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Information page test rebase 5 #30

Closed
wants to merge 34 commits into from

Conversation

nehakerung
Copy link
Contributor

What is the context of this PR?

Describe what you have changed and why, link to other PRs or Issues as appropriate.

How to review

Describe the steps required to test the changes (include screenshots if appropriate).

Follow-up Actions

List any follow-up actions (if applicable), like needed documentation updates or additional testing.

nehakerung and others added 30 commits November 18, 2024 14:39
Addition of InformationPage class in models

Changes to InformationPage class models

Front end creation

Addition of template location and minor changes on information_page template for testing

Added cms.standard_pages to installed_apps

Updated apps.py for standard_pages to be similar to pre-existing apps

Modified InformationPage in models

Updated template for informationPage

Modified models for standard_pages

Modified front end

working branch
* Replace `pytest` with Django's built-in runner

* Drop whitenoise public directory

* Correctly collect coverage for parallel test runs

* Note why certain fixtures are created with each test
…d to reflect the InformationPage model changes
* Add the Contact Details snippet
   https://jira.ons.gov.uk/browse/CMS-80
* Add a basic table block
* Add the release calendar app with models
* Programmatically create the release calendar index
* Add the basic templates
* Add a base form class for easier validation
* Add icons to the various panels
* Add validation logic
* Update templates
* Add tests
* Expand core tests
* Expand coverage configuration
  adds a few extra files to the ignore.
  and explicitly filters the RemovedInDjango60Warning

* Tidy up based on code review
  * Prevent release calendar page deletion through the UI
  * Move the changes to the release date below contact details
    e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
* Fail if under 90% test coverage
* Comment out the scheduler image

* Remove scheduler from Procfile
* Add skeleton models for Theme / Topic pages
* Add base analysis series and page models
* Use a custom icon for the contact detail snippet
* Update the StreamField block template to pass the block ID to its children
* Set parent/subpage types for the new page models
* Wire in the analysis page template
* Add series functionality (latest/previous releases)
* Add tests and fail if coverage under 90%
* Tidy up based on code review
  * Make the accredited / census blocks separate includes
  * Include changes to release dates when status is confirmed
  * Allow setting the release date when switching to confirmed
  * Only allow release date or text, not both
  * Prevent release calendar page deletion through the UI
  * Move the changes to the release date below contact details
    e.g. https://www.ons.gov.uk/releases/disabilitypaygapsintheuk2014to2023
  * Switch to using a StreamField for the release page related links
  * Disable the "too-few-public-methods" pylint check globally
  * Make the equation/ONS embed check reusable
nehakerung and others added 4 commits November 18, 2024 14:41
* Fix `KeyError 'changes_to_release_date'`
  Cannot quite reproduce in tests nor locally
* Fix typo in Analysis series help text
* Further tidy ups
@nehakerung nehakerung closed this Nov 18, 2024
@nehakerung nehakerung deleted the information-page-test-rebase-5 branch November 18, 2024 14:53
@sanjeevz3009
Copy link
Contributor

Teaching Neha how to rebase and sign unverified commits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants