Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial repository and Wagtail setup #3

Merged
merged 39 commits into from
Oct 28, 2024
Merged

Conversation

zerolab
Copy link
Contributor

@zerolab zerolab commented Oct 17, 2024

Covers CMS-73 and CMS-74.
The commits should be atomic.

  • Bumps Python to 3.12, adds Wagtail 6.2.2 and Django to 5.1
  • Docker/docker-compose. Dockerfile provisions for cached steps
  • ruff, pylint, mypy for linting / type checking
  • pytest for testing
  • barebones Wagtail skeleton with a number of relevant blocks from Alpha

@zerolab zerolab marked this pull request as draft October 17, 2024 08:56
@zerolab zerolab force-pushed the feature/initial-repository-setup branch 2 times, most recently from 02632d3 to d9194d0 Compare October 18, 2024 08:26
@zerolab zerolab marked this pull request as ready for review October 18, 2024 08:35
@zerolab zerolab force-pushed the feature/initial-repository-setup branch from d9194d0 to d3c5053 Compare October 18, 2024 08:50
@zerolab zerolab force-pushed the feature/initial-repository-setup branch from c35ac7e to ab352b8 Compare October 18, 2024 11:26
@zerolab zerolab force-pushed the feature/initial-repository-setup branch 6 times, most recently from ae0f5d6 to 975746b Compare October 21, 2024 10:42
@zerolab zerolab requested a review from MebinAbraham October 21, 2024 10:53
@zerolab zerolab force-pushed the feature/initial-repository-setup branch 3 times, most recently from 3ccc8e2 to 78aa073 Compare October 21, 2024 11:46
@zerolab zerolab force-pushed the feature/initial-repository-setup branch from 92abb2b to 86993a8 Compare October 22, 2024 18:19
@zerolab zerolab requested a review from MebinAbraham October 25, 2024 11:27
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a small section in the README about, Migrations:

  • what it is (link to django docs for further reading)
  • how to generate them
  • when to generate them
  • how to apply then.

@zerolab zerolab requested a review from MebinAbraham October 25, 2024 13:57
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments to resolve.

@zerolab zerolab merged commit 4050d8f into main Oct 28, 2024
7 checks passed
@zerolab zerolab deleted the feature/initial-repository-setup branch October 28, 2024 11:23
Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants