Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Docker Desktop setup with Colima #24

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

MebinAbraham
Copy link
Contributor

@MebinAbraham MebinAbraham commented Nov 12, 2024

What is the context of this PR?

Replaced the requirement for Docker and Docker Compose via Docker Desktop with Colima.

Before installing Colima, make sure you uninstall Docker Desktop. If you run into issue, please first check the troubleshooting guide.

How to review

Ensure the project can be set up as-is with Colima.

@MebinAbraham MebinAbraham requested a review from a team as a code owner November 12, 2024 07:58
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency note LGTM.

I wonder if we want the

Before installing Colima, make sure you uninstall Docker Desktop. If you run into issue, please first check the troubleshooting guide.

line there as well, at least in the transitionary period

@MebinAbraham
Copy link
Contributor Author

The dependency note LGTM.

I wonder if we want the

Before installing Colima, make sure you uninstall Docker Desktop. If you run into issue, please first check the troubleshooting guide.

line there as well, at least in the transitionary period

That was more for compliance. They can co-exist: https://github.com/abiosoft/colima/blob/main/docs/FAQ.md#can-it-run-alongside-docker-for-mac

Copy link
Contributor

@kacperpONS kacperpONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might for dev's convenience to add a note about the Colima autostart.
That should probably live in the linked document not here, so I'm not going to block on this.

@AWitcherONS
Copy link
Contributor

Instructions Good!
Make Brilliant! python version picking up
Make test produces error

@MebinAbraham MebinAbraham merged commit 65563ea into main Nov 12, 2024
7 checks passed
@MebinAbraham MebinAbraham deleted the chore/migrate-docker-desktop-to-colima-CMS-206 branch November 12, 2024 13:02
@sanjeevz3009 sanjeevz3009 self-requested a review November 14, 2024 12:30
Copy link
Contributor

@sanjeevz3009 sanjeevz3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read!

nehakerung added a commit that referenced this pull request Nov 19, 2024
* Standard_pages app creation

* Django models for information page updated and the template for the information page tweaked

* Replace `pytest` with Django's built-in runner (#18)

* Release calendar pages (#16)

* Replace Docker Desktop setup with Colima (#24)

* Add Cookie banner and Google Tag Manager snippet (#19)

* Analysis page and series (#20)

* Addition of equation partials

* Repeated code remove, /media added to .gitignore, media file removed

* Related pages InlinePanel added. Add Info Template updated.

---------


Co-authored-by: Neha <[email protected]>
Co-authored-by: Sanjeev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants