Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisionally comment out --mount while deploying to Heroku #12

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

zerolab
Copy link
Contributor

@zerolab zerolab commented Oct 28, 2024

Temporarily disable BuildKit cache as Heroku doesn't support it

@zerolab zerolab requested a review from a team as a code owner October 28, 2024 13:42
@ababic
Copy link
Contributor

ababic commented Oct 28, 2024

@zerolab Are there any implications for local dev here?

@zerolab
Copy link
Contributor Author

zerolab commented Oct 28, 2024

@ababic rebuilds take longer. No difference from the Alpha approach

@zerolab zerolab requested a review from RealOrangeOne October 28, 2024 15:29
@zerolab
Copy link
Contributor Author

zerolab commented Oct 28, 2024

erm, Jake, do ignore that last request. I removed dissemination/cms from reviewers and instead it logged that I explicitly requested you 🤦🏼

@zerolab zerolab merged commit a78c83d into main Oct 28, 2024
7 checks passed
@zerolab zerolab deleted the chore/de-buildkit-dockerfile-for-heroku branch October 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants