Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search button to header #3483

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Jan 30, 2025

What is the context of this PR?

ONSDESYS-162
Added a search button to the header component. Clicking the button opens a panel containing a search input and a list of popular searches.

How to review this PR

Check that example-header-with-search-button has the new search button and has the design as specified in figma

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 586e897
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/679c8d8849778600081ea22b
😎 Deploy Preview https://deploy-preview-3483--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons force-pushed the feature/162-header-search-button branch from 5a42c21 to 7bf2beb Compare January 30, 2025 15:18
@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Enhancement Change of existing feature label Jan 30, 2025
@precious-onyenaucheya-ons precious-onyenaucheya-ons marked this pull request as ready for review January 31, 2025 08:45
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team as a code owner January 31, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant