Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote from BLAIS5-4597 to main #1

Merged
merged 40 commits into from
Jan 30, 2025
Merged

Promote from BLAIS5-4597 to main #1

merged 40 commits into from
Jan 30, 2025

Conversation

social-surveys-blaise-concourse
Copy link
Collaborator

Auto generated by concourse:

Promote from BLAIS5-4597 to main

Comment on lines +29 to +34
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
with:
languages: ${{ matrix.language }}

- name: Autobuild

Check notice

Code scanning / CodeQL

Workflow Should Use Default Setup

CodeQL Action could use default setup instead of advanced configuration.
Comment on lines +11 to +35
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ 3.9 ]
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
pip install poetry
poetry install
- name: Run pytest
run: |
poetry run python -m pytest --cov=./
poetry run python -m coverage xml -i
- name: Codecov
uses: codecov/[email protected]
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true

lint:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions Job or Workflow does not set permissions
poetry run python -m pytest --cov=./
poetry run python -m coverage xml -i
- name: Codecov
uses: codecov/[email protected]

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow

Unpinned 3rd party Action 'Test coverage report' step [Uses Step](1) uses 'codecov/codecov-action' with ref 'v1.5.0', not a pinned commit hash
Comment on lines +36 to +71
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ 3.9 ]
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
pip install poetry
poetry install
- name: Run black
run: poetry run black --check .
- name: Run isort
run: poetry run isort --check .

# check-types:
# runs-on: ubuntu-latest
# strategy:
# matrix:
# python-version: [ 3.9 ]
# steps:
# - uses: actions/checkout@v2
# - name: Set up Python ${{ matrix.python-version }}
# uses: actions/setup-python@v2
# with:
# python-version: ${{ matrix.python-version }}
# - name: Install dependencies
# run: |
# pip install poetry
# poetry install
# - name: Run mypy
# run: poetry run mypy .

Check warning

Code scanning / CodeQL

Workflow does not contain permissions

Actions Job or Workflow does not set permissions
Copy link

codecov bot commented Jan 29, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@SidraJaved SidraJaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, discussed and tested with Ben :)

@SidraJaved SidraJaved marked this pull request as ready for review January 30, 2025 12:24
@SidraJaved SidraJaved merged commit e61cc57 into main Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants