Open
Conversation
| this.color =color; | ||
| this.type =type; | ||
| this.year =year; | ||
|
|
There was a problem hiding this comment.
Also, with the way you assigned 'Vehicle' to this.name. that means all classes inherited will always have 'vehicle' as the name. I'm not sure that's what you intended to do.
|
|
||
| } | ||
| //instatiating a car model of a vehicle | ||
| let v = new Vehicle(red,car); |
There was a problem hiding this comment.
This is not a good variable name, variable names should be descriptive
|
|
||
|
|
||
|
|
||
|
No newline at end of file |
There was a problem hiding this comment.
Always end your files with a new line
| it('it should be a string', () => { | ||
| assert.typeOf(result, 'string') | ||
| }); | ||
| }); |
There was a problem hiding this comment.
You wrote tests but your tests are not running because you didn't update your package.json with the test script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
It is shows the implementation of OOP
###Description of the task to be completed
It shows how to implement OOP in areal life scenerio
How should this e manually tested
By navigating to the main.js page
Any background context you want to provide
N/A