Add diagonal covariance option for dual estimation + hmm_features #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for diagonal covariance matrices in the HMM dual estimation pipeline, matching the existing capability in the main HMM model (
config.diagonal_covariances). This enables session-specific re-estimation of variance-only observation models, useful for parcellations or analyses where cross-channel covariance structure is not required or not identifiable.Key changes
hmm_dual_estimation(inanalysis/post_hoc.py) with a new argumentdiagonal_covariances=False.n_channels × n_channels) with off-diagonals zeroed.hmm_featuresto:diagonal_covariances=True,Model.dual_estimationto respectconfig.diagonal_covariances.Motivation
Enable dual-estimation workflows where only state-specific variances are needed (e.g., amplitude/power-driven dynamics), consistent with the diagonal-covariance option already available during HMM training. This brings feature parity to post-hoc analysis functions.
Notes