Skip to content

Remove geoalchemy dep #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2017
Merged

Remove geoalchemy dep #72

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c46d92d
Remove geoalchemy references in setup.py
ocefpaf Mar 15, 2017
de985a9
remove sqlalchemy from requirements.txt
ocefpaf Mar 15, 2017
07a6cf5
review actions
ocefpaf May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
pyodbc
six
sqlalchemy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is sqlalchemy being removed here? Is it being handled as a requirement/dependency somewhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but since we do import it directly in odm2api I guess it is better to leave it untouched.
We never know if the other dependencies that brings it will drop it in the future.

#-e git+https://github.com/ODM2/[email protected]#egg=geoalchemy-0.7.4
#shapely
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well also remove the commented-out shapely. It's pointless or totally optional w/o geoalchemy.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

pandas
#psycopg2 # Commented out because I could not pip install it.
5 changes: 0 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,9 @@
# 'pyodbc',
# 'six',
# 'sqlalchemy',
# 'geoalchemy>=0.7.3',
# 'shapely',
# 'pandas',
# ],
# dependency_links- geoalchemy from the ODM repository
dependency_links=[
"git+https://github.com/ODM2/[email protected]#egg=geoalchemy-0.7.4"
],

# List additional groups of dependencies here (e.g. development
# dependencies). You can install these using the following syntax,
Expand Down