Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.x compatibility #58

Merged
merged 5 commits into from
Apr 21, 2016
Merged

python 3.x compatibility #58

merged 5 commits into from
Apr 21, 2016

Conversation

miguelcleon
Copy link
Member

Two changes for compatiability with python 3.x:

print statements were changed to enclose the printed text in parenthesis.

A similar/related changes to exceptions:

Where in python 2.x this was valid:

except Exception, e:

In python 3.x it needs to be:

except Exception as e:

None of these should cause any functional changes.

@valentinedwv
Copy link
Member

Looks good.

@Castronova
Copy link
Contributor

I ran into a geoalchemy error when installing this PR using Python 3, see #59

@valentinedwv
Copy link
Member

@miguelcleon can you enable a couple versions of python 3.0 in .travis.yml

@miguelcleon miguelcleon merged commit 5ae46f3 into ODM2:master Apr 21, 2016
@miguelcleon
Copy link
Member Author

Looks like mysql-python also does not yet support Python 3.x
It does build properly for Python 2.7, so this still works and are changes that will need to be made eventually.
https://travis-ci.org/miguelcleon/ODM2PythonAPI/builds/124805005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants