[18.0][FW] membership_extension: multiple ports from 16.0#215
Merged
OCA-git-bot merged 4 commits intoOCA:18.0from Feb 5, 2026
Merged
Conversation
When a membership got cancelled and, later, restarted, we still had a cancellation date set, leading to the sensation that it was still cancelled. With this refactor, when a cancellation date is earlier than a future start date, cancellation info is removed from the partner. BTW I improved a few things: - Removed old dead code that is no longer necessary in v16. - Fix a test that was checking what happened when a membership line was cancelled before its start date. It seems a wrong use case because memberships are only supposed to be cancelled during the membership, and not before starting it. - Free members need to be considered members too. - Migration script. @moduon MT-8237
Before this fix, when creating many memberships at once, only the last one was really created. @moduon MT-8237
…ast start 93c8e75 was supposed to fix OCA#126 but in reality the problem was the misunderstanding of the feature. Here I'm reverting that commit and changing the help attribute of the fields to be more clear when explaining what each one means. The feature is now tested. The details are explained in OCA#190 (comment) (option A). Fixes OCA#190 @moduon MT-8237
chienandalu
reviewed
Feb 2, 2026
yajo
force-pushed
the
oca-port-membership_extension-16.0-to-18.0-4a0067
branch
from
9738254 to
22948e6
Compare
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at ca92b05. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port from 16.0 to 18.0:
@moduon MT-13535