Skip to content

[16.0][IMP] membership_extension: remove Member Free membership when Invoice is created #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clebersantz wants to merge 8 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] membership_extension: remove Member Free membership when Invoice is created #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73d38cc
update partner free member when invoiced
clebersantz Aug 11, 2025
28860dc
update member view filter to add waiting status
clebersantz Aug 11, 2025
2ddc55b
remove Member free membership when Invoice is created
clebersantz Aug 11, 2025
507089f
remove Member free membership when Invoice is created
clebersantz Aug 11, 2025
a1be4ff
remove Member free membership when Invoice is created
clebersantz Aug 11, 2025
124d980
remove Member free membership when Invoice is created
clebersantz Aug 11, 2025
3aa2c85
solve view indentation problem
clebersantz Aug 11, 2025
d330661
solve view indentation problem
clebersantz Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions membership_extension/models/account_move_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ def create(self, vals_list):
for line in lines:
if line.move_id.move_type == "out_invoice" and line.product_id.membership:
line.membership_lines.write({"state": "waiting"})
for partner in line.membership_lines.mapped("partner"):
partner.write({"free_member": False})
Comment on lines +21 to +22
Copy link
Copy Markdown
Member

@yajo yajo Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Same but simpler and faster:

Suggested change
for partner in line.membership_lines.mapped("partner"):
partner.write({"free_member": False})
line.membership_lines.partner.free_member = False

return lines

def unlink(self):
Expand Down
7 changes: 7 additions & 0 deletions membership_extension/views/res_partner_view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@
<field name="model">res.partner</field>
<field name="inherit_id" ref="membership.view_res_partner_member_filter" />
<field name="arch" type="xml">
<xpath expr="//filter[@name='all_members']" position="attributes">
<attribute
name="domain"
>[('membership_state', 'in', ['invoiced', 'paid', 'free', 'waiting'])]</attribute>
<attribute name="help">Invoiced/Paid/Free/Waiting</attribute>
<attribute name="string">Members</attribute>
</xpath>
<xpath expr="//group" position="inside">
<filter
string="Last Start Month"
Expand Down