[16.0][MIG] membership_variable_period by carmenbianca · Pull Request #133 · OCA/vertical-association

carmenbianca · 2022-10-10T10:29:38Z

Migrated from v14.0. Tagging @flachica from #130

Depends on [16.0][MIG] membership_extension #132

rafaelbn · 2022-12-20T15:58:04Z

/ocabot rebase

OCA-git-bot · 2022-12-20T15:58:12Z

@rafaelbn The rebase process failed, because command git push --force coopiteasy tmp-pr-133:16.0-mig-membership_variable_period failed with output:

remote: Permission to coopiteasy/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/vertical-association/': The requested URL returned error: 403

rafaelbn · 2022-12-20T15:58:24Z

/ocabot migration membership_variable_period

carmenbianca · 2022-12-20T15:59:32Z

@rafaelbn rebased

rafaelbn · 2022-12-20T16:22:27Z

Runboat log

+ bash /runboat/runboat-clone-and-install.sh
+ rm -fr '/mnt/data/*'
+ rm -fr /mnt/data/odoo-addons-dir
+ mkdir -p /mnt/data/odoo-addons-dir
+ cd /mnt/data/odoo-addons-dir
+ curl -sSL https://github.com/oca/vertical-association/tarball/d370881ab90cf5e0195d38e27df3f34a440e9d30
+ tar zxf - --strip-components=1
+ INSTALL_METHOD=oca_install_addons
+ [[ oca_install_addons == \o\c\a\_\i\n\s\t\a\l\l\_\a\d\d\o\n\s ]]
+ oca_install_addons
+ setuptools-odoo-get-requirements --include-addons --addons-dir /mnt/data/odoo-addons-dir
/root/.local/pipx/shared/lib/python3.8/site-packages/_distutils_hack/__init__.py:18: UserWarning: Distutils was imported before Setuptools, but importing Setuptools also replaces the `distutils` module in `sys.modules`. This may lead to undesirable behaviors or errors. To avoid these issues, avoid using distutils directly, ensure that setuptools is installed in the traditional way (e.g. not an editable install), and/or make sure that setuptools is always imported before distutils.
  warnings.warn(
/root/.local/pipx/shared/lib/python3.8/site-packages/_distutils_hack/__init__.py:33: UserWarning: Setuptools is replacing distutils.
  warnings.warn("Setuptools is replacing distutils.")
+ cat test-requirements.txt
odoo-addon-membership_extension>=16.0dev,<16.1dev
odoo>=16.0a,<16.1dev
+ pip install -r test-requirements.txt
Looking in indexes: https://wheelhouse.odoo-community.org/oca-simple-and-pypi
ERROR: Could not find a version that satisfies the requirement odoo-addon-membership_extension<16.1dev,>=16.0dev (from versions: 15.0.1.0.0.3)
ERROR: No matching distribution found for odoo-addon-membership_extension<16.1dev,>=16.0dev

rafaelbn · 2022-12-20T16:27:33Z

Hello @sbidoul , could you please give us a clue to solve this runboat log? #133 (comment) @yajo do you have any idea? Thank you!

sbidoul · 2022-12-20T18:06:47Z

@rafaelbn membership_extension is not merged, hence not available for installation.

fcvalgar · 2022-12-21T16:43:32Z

@carmenbianca can you rebase? please.

rafaelbn · 2022-12-22T02:49:59Z

/ocabot rebase

OCA-git-bot · 2022-12-22T06:03:59Z

@rafaelbn The rebase process failed, because command git push --force coopiteasy tmp-pr-133:16.0-mig-membership_variable_period failed with output:

remote: Permission to coopiteasy/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/vertical-association/': The requested URL returned error: 403

Variable period for memberships =============================== Current membership module allows to set products that define a fixed period for a membership. This is good when the quotas are defined periodically, and when you become a member, you are until the end of that quota cycle. But a lot of times, membership quotas express an amount of time that you gain the membership. For example, one year since the subscription. This module allows to make it in Odoo, using current membership features, and adapting them for this purpose. As now the quota is not attached to a fixed period, you can also invoice more than one quantity for being a member for the corresponding number of periods. Finally, a cron has been included that triggers the recalculation of the membership state, allowing to have "old members", which doesn't work well on standard. Usage ===== Define a member product, and select 'Variable periods' in the field *Membership type*. You will be able to select them the period for the membership in quantity and interval. Signed-off-by: Carmen Bianca Bakker <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]>

Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-12.0/vertical-association-12.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_variable_period/pt_BR/ Signed-off-by: Carmen Bianca Bakker <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_variable_period.pot Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]>

carmenbianca · 2022-12-23T08:09:27Z

@rafaelbn Done.

Do you know which button I need to press to make sure that the ocabot rebase command works in the future?

sbidoul · 2022-12-23T08:18:17Z

Do you know which button I need to press to make sure that the ocabot rebase command works in the future?

I don't think there is one if the source branch belongs to an organization fork as opposed to a personal account.

pedrobaeza · 2022-12-23T08:23:40Z

Yes, it's a problem/undesired feature of GitHub, that doesn't allow maintainers to push to organization branches. Last time I checked, they don't want to change this behavior.

carmenbianca · 2022-12-23T09:04:19Z

That's a pity :( Thank you for your swift answers @sbidoul @pedrobaeza

I'll add a low-priority discussion item about this for our next internal meeting.

fcvalgar

LGTM, thank you @carmenbianca

fcvalgar · 2023-01-02T17:09:41Z

internal @moduon MT-1834

chienandalu · 2023-01-17T10:56:45Z

/ocabot merge nobump

OCA-git-bot · 2023-01-17T10:56:53Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-133-by-chienandalu-bump-nobump, awaiting test results.

Signed-off-by chienandalu

OCA-git-bot · 2023-01-17T11:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-01-17T11:04:15Z

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-133-by-chienandalu-bump-nobump, awaiting test results.

OCA-git-bot · 2023-01-17T11:11:40Z

Congratulations, your PR was merged at e06e340. Thanks a lot for contributing to OCA. ❤️

rafaelbn · 2025-08-19T18:54:14Z

/ocabot migration membership_variable_period

OCA-git-bot · 2025-08-19T18:54:24Z

The migration issue (#131) has not been updated to reference the current pull request because a previous pull request (#205) is not closed.
Perhaps you should check that there is no duplicate work.
CC @flaenen

rafaelbn · 2025-08-19T18:56:05Z

/ocabot migration membership_variable_period

carmenbianca force-pushed the 16.0-mig-membership_variable_period branch from 4b5ed70 to d5aa360 Compare October 10, 2022 10:58

OCA-git-bot added this to the 16.0 milestone Dec 20, 2022

OCA-git-bot mentioned this pull request Dec 20, 2022

Migration to version 16.0 #131

Open

11 tasks

rafaelbn added the needs review label Dec 20, 2022

carmenbianca force-pushed the 16.0-mig-membership_variable_period branch from d5aa360 to d370881 Compare December 20, 2022 15:59

rafaelbn closed this Dec 20, 2022

rafaelbn reopened this Dec 20, 2022

rafaelbn added needs fixing and removed needs review labels Dec 20, 2022

rafaelbn added needs review and removed needs fixing labels Dec 21, 2022

pedrobaeza and others added 9 commits December 23, 2022 09:08

OCA Transbot updated translations from Transifex

e8c113a

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[FIX] Optimizing check_membership_expiry partners search

4582afc

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[MIG] Make modules uninstallable

1dc3854

Signed-off-by: Carmen Bianca Bakker <[email protected]>

OCA Transbot updated translations from Transifex

0d4bb9d

Signed-off-by: Carmen Bianca Bakker <[email protected]>

Exclude current line when searching for other membership_lines (OCA#9)

69a3c68

Signed-off-by: Carmen Bianca Bakker <[email protected]>

membership_extension (OCA#21)

e579a43

Signed-off-by: Carmen Bianca Bakker <[email protected]>

OCA Transbot updated translations from Transifex

e22484a

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[MIG] membership_variable_period: Migration to 10.0

b484602

Signed-off-by: Carmen Bianca Bakker <[email protected]>

Rodrigo Macedo and others added 7 commits December 23, 2022 09:08

pre-commit

3aebbee

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[13.0][MIG] membership_variable_period

fcc56cd

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[IMP] ease extension

6e21545

Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_variable_period.pot Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>

[14.0][MIG] - membership_variable_period

529029f

Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_variable_period.pot Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>

[MIG] membership_variable_period: migration to 15.0.1.0.0

4145d60

Signed-off-by: Carmen Bianca Bakker <[email protected]>

[MIG] membership_variable_period: migration to 16.0.1.0.0

09df6dc

Signed-off-by: Carmen Bianca Bakker <[email protected]>

carmenbianca force-pushed the 16.0-mig-membership_variable_period branch from d370881 to 09df6dc Compare December 23, 2022 08:08

fcvalgar approved these changes Jan 2, 2023

View reviewed changes

PierrickBrun approved these changes Jan 17, 2023

View reviewed changes

OCA-git-bot added the approved label Jan 17, 2023

OCA-git-bot added the bot is merging ⏳ label Jan 17, 2023

OCA-git-bot added a commit that referenced this pull request Jan 17, 2023

Merge PR #133 into 16.0

5983eec

Signed-off-by chienandalu

OCA-git-bot added the ready to merge label Jan 17, 2023

OCA-git-bot merged commit 3084b30 into OCA:16.0 Jan 17, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 17, 2023

Uh oh!

Conversation

carmenbianca commented Oct 10, 2022 • edited by rafaelbn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafaelbn commented Dec 20, 2022

Uh oh!

OCA-git-bot commented Dec 20, 2022

Uh oh!

rafaelbn commented Dec 20, 2022

Uh oh!

carmenbianca commented Dec 20, 2022

Uh oh!

rafaelbn commented Dec 20, 2022

Uh oh!

rafaelbn commented Dec 20, 2022

Uh oh!

sbidoul commented Dec 20, 2022

Uh oh!

fcvalgar commented Dec 21, 2022

Uh oh!

rafaelbn commented Dec 22, 2022

Uh oh!

OCA-git-bot commented Dec 22, 2022

Uh oh!

carmenbianca commented Dec 23, 2022

Uh oh!

sbidoul commented Dec 23, 2022

Uh oh!

pedrobaeza commented Dec 23, 2022

Uh oh!

carmenbianca commented Dec 23, 2022

Uh oh!

fcvalgar left a comment

Choose a reason for hiding this comment

Uh oh!

fcvalgar commented Jan 2, 2023

Uh oh!

chienandalu commented Jan 17, 2023

Uh oh!

OCA-git-bot commented Jan 17, 2023

Uh oh!

OCA-git-bot commented Jan 17, 2023

Uh oh!

OCA-git-bot commented Jan 17, 2023

Uh oh!

OCA-git-bot commented Jan 17, 2023

Uh oh!

rafaelbn commented Aug 19, 2025

Uh oh!

OCA-git-bot commented Aug 19, 2025

Uh oh!

rafaelbn commented Aug 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

carmenbianca commented Oct 10, 2022 •

edited by rafaelbn

Loading