[18.0][MIG] stock_dock: Migration to 18.0 #160

Kimkhoi3010 · 2025-01-08T03:02:32Z

I found only 1 commit to port but it was ignored, I added it to blacklist:

[16.0][FW] stock_dock: port from 14.0 #161

During the migration of the stock_dock module, I identified two issues in the tms module that needed to be addressed. To resolve these issues, I created two separate commits:

Commit 1: The kanban-box in the tms module was deprecated in Odoo. This commit replaces the kanban-box definition with the recommended card template to address the warning.
Commit 2: The group_tms_uom field in the tms module had the same label as group_uom from the product module ("Units of Measure"), causing a conflict. This commit updates the label of group_tms_uom to ensure uniqueness.

rousseldenis · 2025-01-08T08:27:04Z

/ocabot migration stock_dock

rousseldenis · 2025-01-08T08:28:36Z

@Kimkhoi3010 Thanks for this. Could you remove all changes related to other modules?

You should respect flow for migration:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch

tms changes should go in another PR.

Kimkhoi3010 · 2025-01-15T07:49:43Z

@Kimkhoi3010 Thanks for this. Could you remove all changes related to other modules?

You should respect flow for migration:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch

tms changes should go in another PR.

Hi @rousseldenis
I updated by your comment, I have created a PR to fix the issues in tms module: #164

[UPD] Update stock_dock.pot

And filter available docks from a shipment to the current warehouse.

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-stock_dock Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-stock_dock/it/ Translated using Weblate (Italian) Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-stock_dock Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-stock_dock/it/

Currently translated at 83.3% (15 of 18 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-stock_dock Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-stock_dock/es/ Translated using Weblate (Spanish) Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-stock_dock Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-stock_dock/es/

Currently translated at 100.0% (18 of 18 strings) Translation: stock-logistics-transport-16.0/stock-logistics-transport-16.0-stock_dock Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-stock_dock/fr/

bizzappdev · 2025-01-23T10:26:01Z

I'm unsure about the necessity of the checklog_odoo.cfg file. @Kimkhoi3010, could you please explain its inclusion?
I'm not aware of any new standards introduced for OCA.

Kimkhoi3010 · 2025-01-23T11:10:28Z

I'm unsure about the necessity of the checklog_odoo.cfg file. @Kimkhoi3010, could you please explain its inclusion? I'm not aware of any new standards introduced for OCA.

Hi @bizzappdev,
Sorry for my mistake, I did not update carefully.

rousseldenis · 2025-01-23T11:13:23Z

I'm unsure about the necessity of the checklog_odoo.cfg file. @Kimkhoi3010, could you please explain its inclusion? I'm not aware of any new standards introduced for OCA.

@Kimkhoi3010 @bizzappdev That's because on void tests repository main branch, no tests are run. And no tests are declared in this one.

Even if adding that line to configuration solves errors, I always recommend to add a basic test.

@Kimkhoi3010 Here, you can add a test that checks the default warehouse.

bizzappdev · 2025-01-23T11:19:46Z

@Kimkhoi3010 Thank you for the clarification.
@rousseldenis, indeed, adding at least some test cases is better. But strangely, right now, no checklog_odoo.cfg still test builds are passed :)

@Kimkhoi3010 FYI: https://github.com/OCA/management-system/blob/18.0/checklog-odoo.cfg. The file has been added; you might need to take care of other repos you have added them.

rousseldenis · 2025-01-23T11:20:58Z

indeed, adding at least some test cases is better. But strangely, right now, no checklog_odoo.cfg still test builds are passed :)

Because tms module has been merged

Kimkhoi3010 · 2025-01-24T09:19:22Z

I'm unsure about the necessity of the checklog_odoo.cfg file. @Kimkhoi3010, could you please explain its inclusion? I'm not aware of any new standards introduced for OCA.

@Kimkhoi3010 @bizzappdev That's because on void tests repository main branch, no tests are run. And no tests are declared in this one.

Even if adding that line to configuration solves errors, I always recommend to add a basic test.

@Kimkhoi3010 Here, you can add a test that checks the default warehouse.

H

I'm unsure about the necessity of the checklog_odoo.cfg file. @Kimkhoi3010, could you please explain its inclusion? I'm not aware of any new standards introduced for OCA.

@Kimkhoi3010 @bizzappdev That's because on void tests repository main branch, no tests are run. And no tests are declared in this one.

Even if adding that line to configuration solves errors, I always recommend to add a basic test.

@Kimkhoi3010 Here, you can add a test that checks the default warehouse.

Hi @rousseldenis, @bizzappdev
I have updated according to your comment, I have added a basic test

stock_dock/views/stock_dock.xml

bizzappdev

Code and Functional Testing LGTM

OCA-git-bot · 2025-01-24T13:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Kimkhoi3010 marked this pull request as draft January 8, 2025 03:06

Kimkhoi3010 force-pushed the 18.0-mig-stock_dock branch 4 times, most recently from c7a96bd to ca9252f Compare January 8, 2025 04:03

Kimkhoi3010 marked this pull request as ready for review January 8, 2025 04:16

OCA-git-bot added this to the 18.0 milestone Jan 8, 2025

OCA-git-bot mentioned this pull request Jan 8, 2025

Migration to version 18.0 #147

Open

2 tasks

rousseldenis added needs review migration needs fixing and removed needs review labels Jan 8, 2025

Kimkhoi3010 force-pushed the 18.0-mig-stock_dock branch from ca9252f to e2c6475 Compare January 8, 2025 08:37

Kimkhoi3010 marked this pull request as draft January 8, 2025 08:40

Kimkhoi3010 force-pushed the 18.0-mig-stock_dock branch 3 times, most recently from bd944e8 to ea0867c Compare January 15, 2025 07:46

Kimkhoi3010 marked this pull request as ready for review January 15, 2025 07:49

sebalix and others added 9 commits January 15, 2025 15:19

[ADD] shipment_advice: manage (un)loading process

d05ee66

[UPD] Update stock_dock.pot

[ADD] icon.png

4de4fbb

stock_dock 13.0.1.0.1

1864f1f

[IMP] stock_dock: black, isort, prettier

31d8608

[MIG] stock_dock: Migration to 14.0

765b046

[IMP] shipment: bind dock to a warehouse

5d3fcfd

And filter available docks from a shipment to the current warehouse.

stock_dock 14.0.1.1.0

494fbad

[IMP] fix errors from pylint

8adbc9b

[MIG] stock_dock: Migration to 16.0

6dedc17

OCA-git-bot and others added 9 commits January 15, 2025 15:19

stock_dock 16.0.1.0.1

217168a

Added translation using Weblate (Italian)

ad64a70

Added translation using Weblate (Spanish)

5423110

Added translation using Weblate (French)

fa2cb36

[IMP] stock_dock: pre-commit auto fixes

ad87083

oca-port: blacklist PR(s) 116 for stock_dock

c3e476b

Kimkhoi3010 force-pushed the 18.0-mig-stock_dock branch from ea0867c to 8f29415 Compare January 15, 2025 08:19

Kimkhoi3010 force-pushed the 18.0-mig-stock_dock branch from 8f29415 to e29ee9c Compare January 23, 2025 11:07

Kimkhoi3010 force-pushed the 18.0-mig-stock_dock branch from 3bb00fd to 3c55bb2 Compare January 24, 2025 09:16

TDu reviewed Jan 24, 2025

View reviewed changes

stock_dock/views/stock_dock.xml Outdated Show resolved Hide resolved

bizzappdev approved these changes Jan 24, 2025

View reviewed changes

Kimkhoi3010 added 2 commits January 24, 2025 19:08

[MIG] stock_dock: Migration to 18.0

68d9f21

[ADD] - Add test case

fdc2c42

Kimkhoi3010 force-pushed the 18.0-mig-stock_dock branch from 3c55bb2 to fdc2c42 Compare January 24, 2025 12:08

TDu approved these changes Jan 24, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] stock_dock: Migration to 18.0 #160

[18.0][MIG] stock_dock: Migration to 18.0 #160

Kimkhoi3010 commented Jan 8, 2025 •

edited

Loading

rousseldenis commented Jan 8, 2025

rousseldenis commented Jan 8, 2025 •

edited

Loading

Kimkhoi3010 commented Jan 15, 2025 •

edited

Loading

bizzappdev commented Jan 23, 2025

Kimkhoi3010 commented Jan 23, 2025

rousseldenis commented Jan 23, 2025 •

edited

Loading

bizzappdev commented Jan 23, 2025

rousseldenis commented Jan 23, 2025

Kimkhoi3010 commented Jan 24, 2025 •

edited

Loading

bizzappdev left a comment

OCA-git-bot commented Jan 24, 2025

[18.0][MIG] stock_dock: Migration to 18.0 #160

Are you sure you want to change the base?

[18.0][MIG] stock_dock: Migration to 18.0 #160

Conversation

Kimkhoi3010 commented Jan 8, 2025 • edited Loading

rousseldenis commented Jan 8, 2025

rousseldenis commented Jan 8, 2025 • edited Loading

Kimkhoi3010 commented Jan 15, 2025 • edited Loading

bizzappdev commented Jan 23, 2025

Kimkhoi3010 commented Jan 23, 2025

rousseldenis commented Jan 23, 2025 • edited Loading

bizzappdev commented Jan 23, 2025

rousseldenis commented Jan 23, 2025

Kimkhoi3010 commented Jan 24, 2025 • edited Loading

bizzappdev left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 24, 2025

Kimkhoi3010 commented Jan 8, 2025 •

edited

Loading

rousseldenis commented Jan 8, 2025 •

edited

Loading

Kimkhoi3010 commented Jan 15, 2025 •

edited

Loading

rousseldenis commented Jan 23, 2025 •

edited

Loading

Kimkhoi3010 commented Jan 24, 2025 •

edited

Loading