Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] tms: Model description and views #152

Merged
merged 1 commit into from
Nov 6, 2024
Merged

[IMP] tms: Model description and views #152

merged 1 commit into from
Nov 6, 2024

Conversation

max3903
Copy link
Member

@max3903 max3903 commented Nov 3, 2024

No description provided.

@max3903 max3903 added this to the 17.0 milestone Nov 3, 2024
@OCA-git-bot
Copy link
Contributor

Hi @EdgarRetes, @santiagordz,
some modules you are maintaining are being modified, check this out!

@max3903 max3903 mentioned this pull request Nov 3, 2024
Open
1 task
@EdgarRetes
Copy link

LGTM

Christian-RB
Christian-RB approved these changes Nov 6, 2024
View reviewed changes
Copy link

@Christian-RB Christian-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseldenis
Copy link
Contributor

@max3903 Don't forget to improve your commit messages. Thanks

@max3903 max3903 changed the title [IMP] tms [IMP] tms: Model description and views Nov 6, 2024
@max3903
Copy link
Member Author

max3903 commented Nov 6, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-152-by-max3903-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a5b3acc into OCA:17.0 Nov 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4788a4b. Thanks a lot for contributing to OCA. ❤️

@rousseldenis
Copy link
Contributor

@max3903 Don't forget to improve your commit messages. Thanks

I spoke about commit 😓 :

image

@max3903 max3903 deleted the 17.0-imp-tms branch November 6, 2024 15:30
@max3903
Copy link
Member Author

max3903 commented Nov 6, 2024

@rousseldenis Sorry, I thought the pull request title would be used in the merge commit message. I fixed the one in #153.

@rousseldenis
Copy link
Contributor

@rousseldenis Sorry, I thought the pull request title would be used in the merge commit message. I fixed the one in #153.

You can have several commits in the PR :-)

No such process with ocabot merge command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christian-RB Christian-RB Christian-RB approved these changes

Assignees
No one assigned
Labels
bug enhancement merged 🎉 needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@max3903 @OCA-git-bot @EdgarRetes @rousseldenis @Christian-RB