Closed
Conversation
Phase 1: Odoo 18 Compatibility - Fix duplicate _description attribute in SignRequestLog model - Fix translation strings to use lazy evaluation (%(name)s format) - Replace deprecated _ import with request.env._ in controllers - Remove superfluous "installable" key from manifest Phase 2-3: Data Corruption and Crash Fixes - Fix project_task.py write() method to properly handle multi-record updates - Fix _compute_next_item_id to handle empty signatory_data dict - Fix _compute_task_id and _compute_project_id to assign values to all records Phase 4-6: Security and Bug Fixes - Fix security vulnerability in portal_download_signed allowing unauthorized downloads - Fix cancel() method to properly log actions for multiple records All changes verified with pylint-odoo linting.
The getPdfUrl() method in sign_oca_pdf_common.esm.js was using a path-based URL format that causes 404 errors in Odoo 18: - Old: /web/content/sign.oca.request/3/data - New: /web/content?model=sign.oca.request&id=3&field=data The query parameter format is more reliable because: 1. Handles model names with dots (like sign.oca.request) correctly 2. Is the standard format used by other Odoo modules 3. More explicit about the binary field being requested This fixes the blank PDF viewer issue in configure and preview screens.
Contributor
|
Hi @WesleyOliveira98, @etobella, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.