[19.0][MIG] sale_procurement_group_by_line: Migrate to 19.0

[Tatider]

• Major changes were done to the module because "procurement.group" model was converted to "stock.reference" by Odoo SA (more details here).
  • Removed Update of "partner_id" and "move_type" - no fields like these exist in the "stock.reference"
  • Added overload of _prepare_procurement_values because "group_id" is no longer an arguments
  • Removed origin calculation - no longer an argument of _create_procurements function
  • Removed check of stock.move:name - move no longer has name/description field

P.S. An update of tests was required because in Odoo 19.0, the database by default doesn't have Demo Data

[StefanRijnhart]

Thanks!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[StefanRijnhart]

@JordiMForgeFlow @ivantodorovich How is it looking to you at this point?

[JordiMForgeFlow]

LGTM, but in other cases I had to rename a module, the best practice is to rename the entire commit history. Here is how to do it:

git filter-branch --tree-filter 'if [ -d sale_procurement_group_by_line ]; then mv sale_procurement_group_by_line sale_stock_reference_by_line; fi' HEAD git rebase origin/18.0 git push -f

[StefanRijnhart]

@JordiMForgeFlow That is certainly an option, but it can also be said that the rename is a legitimate part of the module history that takes place now, and is reflected in the module's commit history. Also, the rename of the module directory is only part of the work, and there are field names, file names and external references to consider that cannot easily be rewritten in each commit and will be done in a specific commit. You could consider commits with a rewritten directory name misleading, as they make the history of a module less clear.

@pedrobaeza What is considered the best practice when renaming modules? Is it to rewrite the name throughout the git history or do it in a separate renaming commit?

[JordiMForgeFlow]

@StefanRijnhart actually it was @pedrobaeza who explained the procedure to me 😆

[pedrobaeza]

When renaming, if the whole commit history is not renamed, then on next version, the rescue procedure will only catch from the migration commit, losing part of the commit history. Thus, the whole renaming is needed IMO.

[pedrobaeza]

Anyway, you will need an extra commit with the rest of the work of the renaming (translations, complete XML-IDs where needed, etc).

[StefanRijnhart]

OK, thanks for clarifying! @Tatider can you apply the git history rewrite?

[Tatider]

Anyway, you will need an extra commit with the rest of the work of the renaming (translations, complete XML-IDs where needed, etc).
I have already updated the translations files in main migration commit, no XML ID updated needed. Would it be a problem?

[Tatider]

OK, thanks for clarifying! @Tatider can you apply the git history rewrite?

I am trying, but it is not exactly working with just a copy-paste command...

@JordiMForgeFlow are you also sure it should be on top of 18.0 and not 19.0?

[JordiMForgeFlow]

@Tatider yes it should be on top of 19.0, I just copied the template command but you should adapt it to what you need.

[Tatider]

@StefanRijnhart @JordiMForgeFlow the history is now rewritten.

[StefanRijnhart]

Thanks for all the work! Looking real good.

[rvalyi]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-3947-by-rvalyi-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 1e4d71f. Thanks a lot for contributing to OCA. ❤️

[StefanRijnhart]

Rename added to openupgrade 19 apriori in hbrunn/OpenUpgrade#20