[18.0][ADD] purchase_report_discount_visibility#94
Open
AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
Open
[18.0][ADD] purchase_report_discount_visibility#94AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
AungKoKoLin1997 wants to merge 1 commit intoOCA:18.0from
Conversation
yostashiro
suggested changes
Jan 14, 2026
AungKoKoLin1997
force-pushed
the
18.0-add-purchase_report_discount_visibility
branch
from
48a207b to
3241ce9
Compare
yostashiro
reviewed
Jan 15, 2026
AungKoKoLin1997
force-pushed
the
18.0-add-purchase_report_discount_visibility
branch
from
3241ce9 to
e65b82a
Compare
yostashiro
approved these changes
Jan 15, 2026
Member
yostashiro
left a comment
yostashiro
left a comment
There was a problem hiding this comment.
I don't think it was necessarily a good move to move the logic from Python to the template, but it's trivial. LGTM.
AungKoKoLin1997
force-pushed
the
18.0-add-purchase_report_discount_visibility
branch
from
e65b82a to
95a5e31
Compare
yostashiro
reviewed
Jan 15, 2026
purchase_report_discount_visibility/report/purchase_report_templates.xml
Outdated
Show resolved
Hide resolved
AungKoKoLin1997
force-pushed
the
18.0-add-purchase_report_discount_visibility
branch
from
95a5e31 to
6470472
Compare
yostashiro
approved these changes
Jan 15, 2026
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module allows hiding the Discount column in the Purchase Order report, either always or only when all order lines have no discount.
@qrtl QT6324