[FIX] pos_tare : raise an error if the gross weight is not correct

[legalsylvain]

Raise an error if the gross weight is not correct.

Exemple :

before the patch

• a pos order line is added silently, with a qty to 0.

After the patch

• an error is raised.

(Also fix an bad title for another warning).

CC :

• @grap, @quentinDupont, @SandieFavre (Ref : #/board/144/card/1080)
• @Fkawala

[OCA-git-bot]

Hi @Fkawala,
some modules you are maintaining are being modified, check this out!

[ivantodorovich]

Code review LGTM 👍

[Fkawala]

/ocabot merge patch

[OCA-git-bot]

Sorry @Fkawala you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[Fkawala]

I see much activity here, hence I'll shamelessly try to reroute a little bit of it to a related PR #527 that has been waiting to get approved and merged for a while. Sorry + thank you.

[legalsylvain]

Note : also add another fix, regarding a bad overload of the function validate_order that is not overloadable by design. (*) (see similar problem for pos_meal_voucher here.

the confirm action is moved on the scale screen, when user is weighing its product.

(*) : With the curent design, the other core checks are skipped. for exemple, with the non patched current design of pos_tare, the check regarding huge amount is not done.

CC : @quentinDupont

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[houssine78]

@legalsylvain I think that this can be merged

[legalsylvain]

Thanks. indeed, using this patch in production since a month without problem.

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-566-by-legalsylvain-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 3053fde. Thanks a lot for contributing to OCA. ❤️