Skip to content

[IMP] Prevent duplicate module issues when renaming modules. #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddejong-therp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] Prevent duplicate module issues when renaming modules. #434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions openupgradelib/openupgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,10 +1790,11 @@ def update_module_names(cr, namespec, merge_modules=False):
of just a renaming.
"""
for (old_name, new_name) in namespec:
query = "SELECT id FROM ir_module_module WHERE name = %s"
query = "SELECT state FROM ir_module_module WHERE name = %s"
cr.execute(query, [new_name])
row = cr.fetchone()
if row and merge_modules:
replace = row and (row[0] == "uninstalled" or merge_modules)
if replace:
# Delete meta entries, that will avoid the entry removal
# They will be recreated by the new module anyhow.
query = "SELECT id FROM ir_module_module WHERE name = %s"
Expand Down Expand Up @@ -1835,7 +1836,7 @@ def update_module_names(cr, namespec, merge_modules=False):
if version_info[0] > 7 and version_info[0] < 16:
query = "UPDATE ir_translation SET module = %s WHERE module = %s"
logged_query(cr, query, (new_name, old_name))
if merge_modules:
if merge_modules or replace:
# Conserve old_name's state if new_name is uninstalled
logged_query(
cr,
Expand Down