Skip to content

[IMP]convert_field_to_html: manage translated fields#384

Merged
pedrobaeza merged 2 commits intoOCA:masterfrom
elabore-coop:pr-convert-translated-field-to-html
Oct 3, 2024
Merged

[IMP]convert_field_to_html: manage translated fields#384
pedrobaeza merged 2 commits intoOCA:masterfrom
elabore-coop:pr-convert-translated-field-to-html

Conversation

@clementelabore
Copy link
Contributor

Improve convert_field_to_html method: added translate=False parameter to handle translatable fields

@clementelabore
Copy link
Contributor Author

@florian-dacosta

Copy link
Member

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@sebastienbeau
Copy link
Member

@pedrobaeza @legalsylvain maybe this interest you. It replace the following PR : #358


.. versionadded:: 7.0
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add empty lines inside a method, please (and the same for the next one)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty lines still exist

@clementelabore clementelabore force-pushed the pr-convert-translated-field-to-html branch from 8c378b9 to 8a5d4be Compare October 2, 2024 08:48
@clementelabore
Copy link
Contributor Author

What are the next step to merge and create a new release usable with pip ?

@clementelabore clementelabore force-pushed the pr-convert-translated-field-to-html branch from 8a5d4be to 0206473 Compare October 3, 2024 07:10
@clementelabore clementelabore force-pushed the pr-convert-translated-field-to-html branch from 0206473 to b7c7ec9 Compare October 3, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants