[FIX] Convert tax tags based on move type instead of amount.#383
Open
ddejong-therp wants to merge 1 commit intoOCA:masterfrom
Open
[FIX] Convert tax tags based on move type instead of amount.#383ddejong-therp wants to merge 1 commit intoOCA:masterfrom
ddejong-therp wants to merge 1 commit intoOCA:masterfrom
Conversation
pedrobaeza
reviewed
Sep 30, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
You may have tax tags on other moves different from invoices (for example, payroll moves), so I don't think this is correct.
ddejong-therp
force-pushed
the
fix-tax-tags-conversion
branch
from
b7e30f2 to
be8c30a
Compare
ddejong-therp
force-pushed
the
fix-tax-tags-conversion
branch
from
be8c30a to
94e92de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like the title says.
The issue is that tax tags shouldn't be based on whether a line is of positive or negative amount, but e.g. whether it is an 'invoice' or 'refund'.