Skip to content

[IMP] rename_fields: Be able to use a cursor instead of Environment #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rousseldenis wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[IMP] rename_fields: Be able to use a cursor instead of Environment #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcb78a4
[IMP] rename_fields: Be able to use a cursor instead of Environment
rousseldenis Nov 23, 2023
86f48a5
[IMP] add rename_fields_cr, keep rename_fields for backwards compatib…
sbidoul Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions openupgradelib/openupgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,9 +632,16 @@ def rename_columns(cr, column_spec):


def rename_fields(env, field_spec, no_deep=False):
"""Rename fields. Typically called in the pre script. WARNING: If using
this on base module, pass the argument ``no_deep`` with True value for
avoiding the using of the environment (which is not yet loaded).
"""Rename fields. See rename_fields_cr for details.

:param no_deep: If True, avoids to perform any operation that involves
the environment. Not used for now.
"""
return rename_fields_cr(env.cr, field_spec)


def rename_fields_cr(cr, field_spec):
"""Rename fields. Typically called in the pre script.

This, in contrast of ``rename_columns``, performs all the steps for
completely rename a field from one name to another. This is needed for
Expand All @@ -647,18 +654,12 @@ def rename_fields(env, field_spec, no_deep=False):
This method performs also the SQL column renaming, so only one call is
needed.

:param env: Environment/pool variable. The database cursor is the only
thing needed, but added in prevision of TODO tasks for not breaking
API later.
:param field_spec: a list of tuples with the following elements:
* Model name. The name of the Odoo model
* Table name. The name of the SQL table for the model.
* Old field name. The name of the old field.
* New field name. The name of the new field.
:param no_deep: If True, avoids to perform any operation that involves
the environment. Not used for now.
"""
cr = env.cr
for model, table, old_field, new_field in field_spec:
if column_exists(cr, table, old_field):
rename_columns(cr, {table: [(old_field, new_field)]})
Expand Down Expand Up @@ -776,7 +777,7 @@ def rename_fields(env, field_spec, no_deep=False):
(model,),
)
# TODO: Rename when the field in ir_ui_view_custom
if table_exists(env.cr, "mail_alias"):
if table_exists(cr, "mail_alias"):
# Rename appearances on mail alias
cr.execute(
"""
Expand Down