Skip to content

[ADD] new progress decorator based on progressbar module#206

Closed
ypapouin wants to merge 4 commits intoOCA:masterfrom
decgroupe:master
Closed

[ADD] new progress decorator based on progressbar module#206
ypapouin wants to merge 4 commits intoOCA:masterfrom
decgroupe:master

Conversation

@ypapouin
Copy link

@ypapouin ypapouin commented May 1, 2020

This is a first attempt to create a progress decorator.
It was not tested with OpenERP/Odoo Cursor class, I made my tests with the psycopg2._ext.cursor class.

It was discussed here:
OCA/OpenUpgrade#1897

@pedrobaeza
Copy link
Member

Not sure about linking the bar with a row fetch, because progress bar will be associated usually with ORM operations, not with DB fetches. I think a decorator that links the call to a method and a total number would be better, so each time that method is called, you increase the counter.

@legalsylvain
Copy link
Contributor

I think that both (orm operation & DB fetches) are valid and should be covered. (Maybe with two decorators, if a single one is not simple to implement.)

@pedrobaeza
Copy link
Member

Supersede by #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants