[ADD] new progress decorator based on progressbar module#206
Closed
ypapouin wants to merge 4 commits intoOCA:masterfrom
Closed
[ADD] new progress decorator based on progressbar module#206ypapouin wants to merge 4 commits intoOCA:masterfrom
ypapouin wants to merge 4 commits intoOCA:masterfrom
Conversation
Member
|
Not sure about linking the bar with a row fetch, because progress bar will be associated usually with ORM operations, not with DB fetches. I think a decorator that links the call to a method and a total number would be better, so each time that method is called, you increase the counter. |
Contributor
|
I think that both (orm operation & DB fetches) are valid and should be covered. (Maybe with two decorators, if a single one is not simple to implement.) |
Member
|
Supersede by #233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt to create a progress decorator.
It was not tested with OpenERP/Odoo Cursor class, I made my tests with the psycopg2._ext.cursor class.
It was discussed here:
OCA/OpenUpgrade#1897