Skip to content

[16.0][MIG] pim: Migration to 16.0 + remove completeness dependency#184

Closed
myrrkel wants to merge 92 commits intoOCA:16.0from
myrrkel:16.0-mig-pim
Closed

[16.0][MIG] pim: Migration to 16.0 + remove completeness dependency#184
myrrkel wants to merge 92 commits intoOCA:16.0from
myrrkel:16.0-mig-pim

Conversation

@myrrkel
Copy link
Copy Markdown

@myrrkel myrrkel commented Jun 16, 2024

This PR contains initOS migrations:

  • pim
  • product_attribute_set_completeness
  • attribute_set_completeness

and ADD pim_product_attribute_set_completeness

I added a new module pim_product_attribute_set_completeness to remove product_attribute_set_completeness dependency from pim.
This dependency was added to display 2 fields in the product list view. This was adding too much complexity to maintain the pim app because product_attribute_set_completeness depends on attribute_set_completeness, witch depends on component_event (from the 'connector' repository) witch requires cachetools python module.

pim_product_attribute_set_completeness is now adding product_attribute_set_completeness and add the fields in the pim product list view.

Cédric Pigeon and others added 30 commits July 17, 2023 10:33
* Split computed methods in attribute.set.owner.mixin.
* Use assertRaisesRegex in tests to check for exact error message.
* Improve readability of event listner skip_if conditions.
add migration script : fields have been removed from v13 -> v14
@myrrkel myrrkel changed the title [16.0][MIG] pim: Migration to 16.0 + remove completeness dependecy [16.0][MIG] pim: Migration to 16.0 + remove completeness dependency Jun 17, 2024
@simahawk
Copy link
Copy Markdown

Is this replacing completely #165
If yes, @dsolanki-initos fine for you? Could you have a look?
Yet, the history does not look good.
Regarding the refactoring... @rousseldenis could you please give a feedback?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
@myrrkel
Copy link
Copy Markdown
Author

myrrkel commented Jun 9, 2025

@simahawk The history only reflect what has been done. Feel free to fix that if it really matters, but I guess the number of stuck PR on this project is mainly due to the problem explained in the description.

@simahawk
Copy link
Copy Markdown

@simahawk The history only reflect what has been done. Feel free to fix that if it really matters, but I guess the number of stuck PR on this project is mainly due to the problem explained in the description.

History has to be clean. This branch contains merge commits and other things to cleanup.
See guidelines about migration https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

BTW there's a new PR taking care of this #208 . We should probably close this one.

@myrrkel myrrkel closed this Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants