Skip to content

[ADD] replace action.read() by _for_xml_id to avoid access rights issue #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anothingguy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ADD] replace action.read() by _for_xml_id to avoid access rights issue #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion odoo_module_migrate/migration_scripts/migrate_130_140.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,36 @@ def reformat_deprecated_tags(
logger.debug("Reformatted files:\n" f"{list(reformatted_files)}")


def refactor_action_read(**kwargs):
"""
replace action.read() by _for_xml_id to avoid access rights issue

##### case 1: pattern for case action.read[0] right after self.env.ref
## action = self.env.ref('sale.action_orders')
## action = action.read()[0]

##### case 2: pattern for case having new line between action.read[0] and self.env.ref
## action = self.env.ref('sale.action_orders')
## .........
## .........
## action = action.read()[0]
"""
logger = kwargs["logger"]
tools = kwargs["tools"]
module_path = kwargs["module_path"]
file_paths = _get_files(module_path, ".py")

old_term = r"action.*= self.env.ref\((.*)\)((\n.+)+?)?(\n.+)(action\.read\(\)\[0\])"
new_term = r'\2\4self.env["ir.actions.act_window"]._for_xml_id(\1)'
for file_path in file_paths:
logger.debug(f"refactor file {file_path}")
tools._replace_in_file(
file_path,
{old_term: new_term},
log_message="refactor action.read[0] to _for_xml_id",
)


_TEXT_REPLACES = {
".js": {
r"tour\.STEPS\.SHOW_APPS_MENU_ITEM": "tour.stepUtils.showAppsMenuItem()",
Expand All @@ -155,5 +185,5 @@ def reformat_deprecated_tags(

class MigrationScript(BaseMigrationScript):

_GLOBAL_FUNCTIONS = [reformat_deprecated_tags]
_GLOBAL_FUNCTIONS = [reformat_deprecated_tags, refactor_action_read]
_TEXT_REPLACES = _TEXT_REPLACES