[ADD] Add warning to move SUPERUSER_ID to odoo.api#158
Open
jue-adhoc wants to merge 1 commit intoOCA:masterfrom
Open
[ADD] Add warning to move SUPERUSER_ID to odoo.api#158jue-adhoc wants to merge 1 commit intoOCA:masterfrom
jue-adhoc wants to merge 1 commit intoOCA:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a migration warning to alert developers about the relocation of SUPERUSER_ID from the odoo namespace to odoo.api in Odoo 18.0 to 19.0 migration.
- Adds a new YAML configuration file for text warnings during 18.0 to 19.0 migration
- Implements warning message directing developers to use
api.SUPERUSER_IDinstead ofodoo.SUPERUSER_ID
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
odoo_module_migrate/migration_scripts/text_warnings/migrate_180_190/superuserid_odoo_api.yaml
Outdated
Show resolved
Hide resolved
jue-adhoc
force-pushed
the
19.0-t-57439-jue
branch
from
cde9208 to
b42beac
Compare
jue-adhoc
force-pushed
the
19.0-t-57439-jue
branch
from
b42beac to
941f235
Compare
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks, this is useful. However, a false positive is triggered if module code contains api.SUPERUSER_ID, which works in Odoo 18 and probably in earlier versions as well. Is that something you can fix, for instance by limiting only to import statements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info: odoo/odoo@d6a955f10483