[ADD] Add warning for deprecate _notify_progress in favor to _commit_progress#152
Open
ced-adhoc wants to merge 1 commit intoOCA:masterfrom
Open
[ADD] Add warning for deprecate _notify_progress in favor to _commit_progress#152ced-adhoc wants to merge 1 commit intoOCA:masterfrom
ced-adhoc wants to merge 1 commit intoOCA:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds migration support for the deprecated _notify_progress method being replaced with _commit_progress in Odoo 18.0 to 19.0 migration. It provides both automatic replacement for simple cases and warnings for complex patterns that require manual intervention.
- Adds automatic text replacement rules for basic
_notify_progressusage patterns - Includes warning messages to alert developers about deprecated method usage
- Creates migration script structure for Odoo 18.0 to 19.0 version upgrade
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cron_progress.yaml (text_warnings) | Defines warning message for deprecated _notify_progress method usage |
| cron_progress.yaml (text_replaces) | Provides automatic replacement patterns for simple _notify_progress cases |
| migrate_180_190.py | Creates base migration script class for 18.0 to 19.0 migration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
odoo_module_migrate/migration_scripts/text_replaces/migrate_180_190/cron_progress.yaml
Outdated
Show resolved
Hide resolved
ced-adhoc
changed the title
ced-adhoc
force-pushed
the
19.0-t-57439-ced-1
branch
from
466444c to
3771c3f
Compare
ced-adhoc
changed the title
vib-adhoc
force-pushed
the
19.0-t-57439-ced-1
branch
from
3771c3f to
d4f9369
Compare
ced-adhoc
force-pushed
the
19.0-t-57439-ced-1
branch
3 times, most recently
from
912e802 to
5f0b7e8
Compare
ced-adhoc
force-pushed
the
19.0-t-57439-ced-1
branch
from
5f0b7e8 to
e11dcec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add warning for deprecated _notify_progress method in favor to _commit_progress since requires manual intervention.
More information: https://github.com/odoo/odoo/pull/207082/commits