add script to convert states

[jeffery9]

No description provided.

[hailangvn]

Thank you for the work. Please check my comments. Thanks.

[hailangvn]

Please translate the comment to English.

[hailangvn]

I think it is better to skip below logic if it is not states.

Suggested change

	if keyword.arg == "states":
	if keyword.arg != "states":
	continue

[hailangvn]

Suggested change

	if isinstance(keyword.value, ast.Dict):
	# Direct dictionary
	states_value = ast.literal_eval(keyword.value)
	elif isinstance(keyword.value, ast.Name):
	# Variable reference
	var_name = keyword.value.id
	if var_name in variable_definitions:
	states_value = ast.literal_eval(
	variable_definitions[var_name]
	)
	if isinstance(keyword.value, ast.Dict):
	# Direct dictionary
	states_value = ast.literal_eval(keyword.value)
	elif isinstance(keyword.value, ast.Name):
	# Variable reference
	var_name = keyword.value.id
	if var_name in variable_definitions:
	states_value = ast.literal_eval(
	variable_definitions[var_name]
	)

[hailangvn]

Please translate the comment to English.

[hailangvn]

This line causes test failure because lxml.etree is hard coded to write header with single quote. It is better to only write when there is change.

Suggested change

	tree.write(f, pretty_print=True, encoding="utf-8", xml_declaration=True)
	tree.write(f, pretty_print=True, encoding="utf-8",
	doctype='<?xml version="1.0" encoding="utf-8"?>')

[hailangvn]

These two lines are not needed as model_field_mapping[current_model] is not used anywhere and current_model is part of the key used in model_field_mapping.

[hailangvn]

I could not see the benefit of arch_root_copy. Below code prove that it moves, not copies, children from arch_root to arch_root_copy.

Suggested change

	# Create a copy of arch_root to modify independently
	arch_root_copy = et.Element(arch_root.tag, arch_root.attrib)
	for child in arch_root:
	arch_root_copy.append(child)
	# Create a copy of arch_root to modify independently
	arch_root_copy = et.Element(arch_root.tag, arch_root.attrib)
	for child in arch_root:
	arch_root_copy.append(child)
	logger.info(
	f"arch_root_copy, {arch_root_copy}, {len(arch_root_copy)}"
	)
	logger.info(f"arch_root, {arch_root}, {len(arch_root)}")