[IMP] automatically remove @odoo-module from js assets#108
Open
xaviedoanhduy wants to merge 1 commit intoOCA:masterfrom
Open
[IMP] automatically remove @odoo-module from js assets#108xaviedoanhduy wants to merge 1 commit intoOCA:masterfrom
xaviedoanhduy wants to merge 1 commit intoOCA:masterfrom
Conversation
Contributor
|
Should you check that it is in the /static/tests or /static/src folders? |
xaviedoanhduy
force-pushed
the
odoo-module
branch
from
996c297 to
9183915
Compare
Contributor
Author
|
hi @lef-adhoc, |
lef-adhoc
approved these changes
Nov 8, 2024
Contributor
lef-adhoc
left a comment
lef-adhoc
left a comment
There was a problem hiding this comment.
LGTM
@legalsylvain @jjscarafia could you do a review?
bosd
approved these changes
Nov 14, 2024
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need for /** @odoo-module */ anymore
automatically remove it from js assets:
https://github.com/odoo/odoo/pull/142858/