Open
Conversation
Collaborator
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
The test files are too complex imo. The objective is just to test if replacement is OK
- no need to write extra code.
- no need to créate specific files
Otherwise, lgtm. Thanks !
xaviedoanhduy
force-pushed
the
slugify-deprecation
branch
2 times, most recently
from
d1d4323 to
044f896
Compare
Contributor
Author
hi @legalsylvain, I have updated the PR. |
lef-adhoc
approved these changes
Oct 29, 2024
xaviedoanhduy
force-pushed
the
slugify-deprecation
branch
from
044f896 to
fdbe7c3
Compare
xaviedoanhduy
force-pushed
the
slugify-deprecation
branch
from
fdbe7c3 to
5399d67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[IMP] base: promote slugify and slugify_one to base:
https://github.com/odoo/odoo/pull/175041/commits/7c426470f37fa3efefbc37e45f0f6065160cc35d