Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] product_multi_company: don't change rules, but respect previous company assignments #762

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

yajo
Copy link
Member

@yajo yajo commented Jan 29, 2025

Remove lots of code thanks to #760.

Also, call the new fill_company_ids hook, to respect company assignments done before the module installation.

Draft until:

Instructions for functional tests: This refactor is internal and should not be noticed functionally. The module product_multi_company should work just as always. If so, then this is good.

@moduon MT-8873

Sorry, something went wrong.

@yajo yajo force-pushed the 16.0-product_multi_company-fix_hooks branch from dbf4b41 to 02edfb3 Compare January 29, 2025 12:48
@yajo yajo force-pushed the 16.0-product_multi_company-fix_hooks branch from 02edfb3 to ad2634d Compare February 12, 2025 09:23
@yajo yajo marked this pull request as ready for review February 12, 2025 09:23
@pedrobaeza pedrobaeza changed the title [FIX] product_multi_company: don't change rules, but respect previous company assignments [16.0][FIX] product_multi_company: don't change rules, but respect previous company assignments Feb 12, 2025
@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 12, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you include here migration scripts the same as in partner_multi_company?

… company assignments

Remove lots of code thanks to OCA#760.

Also, call the new `fill_company_ids` hook, to respect company assignments done before the module installation.

@moduon MT-8873
@yajo yajo force-pushed the 16.0-product_multi_company-fix_hooks branch from ad2634d to 39e389f Compare February 14, 2025 10:00
@yajo
Copy link
Member Author

yajo commented Feb 14, 2025

You're right, thanks for the review. Script added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants