[18.0][FIX] hr_expense_invoice: Set the correct tax amount on the invoice being created#333
Open
victoralmau wants to merge 1 commit intoOCA:18.0from
Open
Conversation
…eing created Fixes OCA#332
Laikar
approved these changes
Mar 18, 2026
pedrobaeza
reviewed
Mar 18, 2026
| include 1.30 in taxes. | ||
| """ | ||
| tax_amount = self.tax_amount_currency | ||
| if float_is_zero(tax_amount, precision_rounding=self.currency_id.rounding): |
Member
There was a problem hiding this comment.
Why adding this condition? Isn't enough with the following one?
|
Hi! Thanks for working on this PR. I've been doing some testing and I noticed an unexpected behavior:
In my opinion, the total amount shouldn't change just by selecting the vendor. Could you please check this? 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the correct tax amount on the invoice being created
Fixes #332
Please @pedrobaeza and @dtec-landoo can you review it?
@Tecnativa