Skip to content

[15.0][FIX] hr_expense_advance_clearing: skip check clearing amount #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pani-k-folk wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][FIX] hr_expense_advance_clearing: skip check clearing amount #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hr_expense_advance_clearing/models/hr_expense_sheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def _check_constraint_clearing_amount(self):
and x.advance_sheet_residual <= 0.0
and x.state in ["submit", "approve", "post"]
)
if sheets_x: # Advance Sheets with no residual left
if sheets_x and not self.env.context.get("skip_check_clearing_amount", False):
# Advance Sheets with no residual left
raise ValidationError(
_("Advance: %s has no amount to clear")
% ", ".join(sheets_x.mapped("name"))
Expand Down
1 change: 1 addition & 0 deletions hr_expense_advance_clearing/wizard/account_payment_register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def _validate_over_return(self):
)

def action_create_payments(self):
self = self.with_context(skip_check_clearing_amount=True)
if self._context.get("hr_return_advance", False):
self._validate_over_return()
self.expense_post_return_advance()
Expand Down